Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Girlfriend and Boyfriend "hey" and "cheer" animation for no reason #3126

Closed
2 tasks done
Petya2288 opened this issue Aug 28, 2024 · 1 comment
Closed
2 tasks done
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.
Milestone

Comments

@Petya2288
Copy link

Petya2288 commented Aug 28, 2024

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.4.1

Context (Provide images, videos, etc.)

https://github.com/user-attachments/assets/d3ec1f5e-61d1-4730-b324-c17103a6eb60
If you create a new chart and choose boyfriend for playable character and girlfriend for opponent, there will be playing "hey" and "cheer" animation for no reason at the 18th and 27th seconds

Steps to reproduce (or crash logs, errors, etc.)

Create a new chart and choose boyfriend for playable character and girlfriend for opponent and check it

@Petya2288 Petya2288 added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Aug 28, 2024
@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Aug 28, 2024

The bug happens because of this function in PlayState.hx.
Screenshot 2024-08-28 at 5 17 48 AM

This function was made specifically for Tutorial for the hey and cheer animation events. It was probably made before the Play Animation Event was a thing.

There is a pull request that softcodes the Tutorial events, and in turn, fixes the bug (#3007). It is currently in the 0.5.0 milestone, so the fix will be in the next update.

@Petya2288 Petya2288 reopened this Aug 28, 2024
@Hundrec Hundrec added status: resolved The issue has been fixed or the suggestion has been implemented. and removed status: pending triage Awaiting review. labels Jan 24, 2025
@Hundrec Hundrec added this to the 0.5.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

3 participants