Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: onSubStateOpenEnd not called when entering ResultState #3136

Closed
2 tasks done
lemz1 opened this issue Sep 6, 2024 · 1 comment · Fixed by #3138
Closed
2 tasks done

Bug Report: onSubStateOpenEnd not called when entering ResultState #3136

lemz1 opened this issue Sep 6, 2024 · 1 comment · Fixed by #3138
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.

Comments

@lemz1
Copy link
Contributor

lemz1 commented Sep 6, 2024 •
edited
Loading

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Newgrounds (Web)

If you are playing on a browser, which one are you using?

None

Version

0.4.1

Context (Provide images, videos, etc.)

I made a script that overrides onSubStateOpenEnd, for some reason it doesn't work with the ResultState. I know that it is not the script that is the problem, because when entering playmode from chart editor the onSubStateOpenEnd event gets called.

Steps to reproduce (or crash logs, errors, etc.)

No response
@lemz1 lemz1 added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Sep 6, 2024
@lemz1 lemz1 mentioned this issue Sep 7, 2024
Merged
@EliteMasterEric EliteMasterEric added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Sep 19, 2024
@AbnormalPoof
Copy link
Collaborator

Fixed in v0.5.1.

@lemz1 lemz1 closed this as completed Nov 1, 2024
@Hundrec Hundrec added status: resolved The issue has been fixed or the suggestion has been implemented. and removed status: pending pull request Dependent on a pull request that is currently awaiting review. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix onSubStateOpenEnd not being called from Substates lemz1/Funkin
4 participants
@EliteMasterEric @AbnormalPoof @lemz1 @Hundrec