Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Lag on Pico songs (Pico mix) #4299

Open
3 tasks done
Lasercar opened this issue Mar 12, 2025 · 6 comments · May be fixed by FunkinCrew/funkin.assets#143
Open
3 tasks done

Bug Report: Lag on Pico songs (Pico mix) #4299

Lasercar opened this issue Mar 12, 2025 · 6 comments · May be fixed by FunkinCrew/funkin.assets#143
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: optimization Involves a performance issue or a bug which causes lag.

Comments

@Lasercar
Copy link
Contributor

Lasercar commented Mar 12, 2025

Issue Checklist

  • I have read the Contributing Guide
  • I have checked the Issues/Discussions pages to see if my issue has already been reported
  • I have properly titled my issue

Platform

Compiled from GitHub Source Code

Version

Develop branch

Description (include any images, videos, errors, or crash logs)

The more you restart, the worse it seems to get:

2025-03-12.20-24-25.mp4

Steps to Reproduce

  1. Play a pico song (pico mix)
  2. Restart a bunch of times (/ restart whenever a train is passing)
  3. Wait till train passes
  4. ??????
  5. Bug reproduced!
@Lasercar Lasercar added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Mar 12, 2025
@Hundrec Hundrec added type: optimization Involves a performance issue or a bug which causes lag. and removed type: minor bug Involves a minor bug or issue. labels Mar 12, 2025
@JackXson-Real
Copy link

JackXson-Real commented Mar 12, 2025

I'm personally not able to reproduce this (at least to the severity in the video), but I believe this might be related to #3614

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Mar 13, 2025

Issue confirmed.

bug-repro.online-video-cutter.com.mp4

I think this is because the stage script spams the hair blow animation when the train is passing, but Nene doesn't have the animation, which for some reason causes lag (and may even flood Flixel's debug log window)

Image

Preventing the animation from being spammed seems to solve the issue, but it's not a proper fix since the spam is needed or else GF will just play the animation once then freeze until the hairFall anim plays.

bug-not-present.mp4

@JackXson-Real
Copy link

Issue confirmed.

bug-repro.online-video-cutter.com.mp4
I think this is because the stage script spams the hair blow animation when the train is passing, but Nene doesn't have the animation, which for some reason causes lag (and may even flood Flixel's debug log window)

Image

Preventing the animation of being spammed seems to solve the issue, but it's not a proper fix since the spam is needed or else GF will just play the animation once then freeze until the hair fall anim plays.

bug-not-present.mp4

Interesting, I wonder if there is a way to not have it spammed only on pico songs?

@Hundrec Hundrec added status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage Awaiting review. labels Mar 13, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Mar 13, 2025

No idea how the code works, but I'd imagine you could check if a girlfriend has the hair blowing animations and then disable the animation if not

@Hundrec Hundrec added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels Mar 16, 2025
@VioletSnowLeopard
Copy link

Related to trying to play animations that a character doesn't have, a similar issue happens on Pico mixes for Week 2 songs:

Image

The script tries to play the scared animations for both BF and GF whenever a lightning strike happens, but Pico and Nene don't have these. I don't know if this causes as much lag considering that the animation is not spammed, but only played twice per lighting strike.

Interestingly, the script for the normal stage, spookyMansion.hxc, does check whether the characters have the scared animation before trying to play it:

if (getBoyfriend() != null && getBoyfriend().hasAnimation('scared')) {
	getBoyfriend().playAnimation('scared', true, true);
}

if (getGirlfriend() != null && getGirlfriend().hasAnimation('scared')) {
	getGirlfriend().playAnimation('scared', true, true);
}

It seems that this was forgotten in spookyMansionErect.hxc:

if (getBoyfriend() != null) {
	getBoyfriend().playAnimation('scared', true, true);
}

if (getGirlfriend() != null) {
	getGirlfriend().playAnimation('scared', true, true);
}

@Hundrec
Copy link
Collaborator

Hundrec commented Mar 16, 2025

Good find!
Maybe 0.6.0 will have those animations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants