Bug Report: Lag on Pico songs (Pico mix)

[Lasercar]

Issue Checklist

• I have read the Contributing Guide
• I have checked the Issues/Discussions pages to see if my issue has already been reported
• I have properly titled my issue

Platform

Compiled from GitHub Source Code

Version

Develop branch

Description (include any images, videos, errors, or crash logs)

The more you restart, the worse it seems to get:

2025-03-12.20-24-25.mp4

Steps to Reproduce

1. Play a pico song (pico mix)
2. Restart a bunch of times (/ restart whenever a train is passing)
3. Wait till train passes
4. ??????
5. Bug reproduced!

[JackXson-Real]

I'm personally not able to reproduce this (at least to the severity in the video), but I believe this might be related to #3614

[NotHyper-474]

Issue confirmed.

bug-repro.online-video-cutter.com.mp4

I think this is because the stage script spams the hair blow animation when the train is passing, but Nene doesn't have the animation, which for some reason causes lag (and may even flood Flixel's debug log window)

Preventing the animation from being spammed seems to solve the issue, but it's not a proper fix since the spam is needed or else GF will just play the animation once then freeze until the hairFall anim plays.

bug-not-present.mp4

[JackXson-Real]

Issue confirmed.

bug-repro.online-video-cutter.com.mp4
I think this is because the stage script spams the hair blow animation when the train is passing, but Nene doesn't have the animation, which for some reason causes lag (and may even flood Flixel's debug log window)

Preventing the animation of being spammed seems to solve the issue, but it's not a proper fix since the spam is needed or else GF will just play the animation once then freeze until the hair fall anim plays.

bug-not-present.mp4

Interesting, I wonder if there is a way to not have it spammed only on pico songs?

[Hundrec]

No idea how the code works, but I'd imagine you could check if a girlfriend has the hair blowing animations and then disable the animation if not

[VioletSnowLeopard]

Related to trying to play animations that a character doesn't have, a similar issue happens on Pico mixes for Week 2 songs:

The script tries to play the scared animations for both BF and GF whenever a lightning strike happens, but Pico and Nene don't have these. I don't know if this causes as much lag considering that the animation is not spammed, but only played twice per lighting strike.

Interestingly, the script for the normal stage, spookyMansion.hxc, does check whether the characters have the scared animation before trying to play it:

if (getBoyfriend() != null && getBoyfriend().hasAnimation('scared')) {
	getBoyfriend().playAnimation('scared', true, true);
}

if (getGirlfriend() != null && getGirlfriend().hasAnimation('scared')) {
	getGirlfriend().playAnimation('scared', true, true);
}

It seems that this was forgotten in spookyMansionErect.hxc:

if (getBoyfriend() != null) {
	getBoyfriend().playAnimation('scared', true, true);
}

if (getGirlfriend() != null) {
	getGirlfriend().playAnimation('scared', true, true);
}

[Hundrec]

Good find!
Maybe 0.6.0 will have those animations...