Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Change the way to unmute players vocal #4313

Open
3 tasks done
realClam12 opened this issue Mar 14, 2025 · 0 comments · May be fixed by #4314
Open
3 tasks done

Enhancement: Change the way to unmute players vocal #4313

realClam12 opened this issue Mar 14, 2025 · 0 comments · May be fixed by #4314
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: enhancement Involves an enhancement or new feature.

Comments

@realClam12
Copy link

realClam12 commented Mar 14, 2025

Issue Checklist

  • I have read the Contributing Guide
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested
  • I have properly titled my enhancement

What is your suggestion, and why should it be implemented?

Is it possible to change how the game unmute players vocal?

I know this game mutes the vocal when player misses and won't unmute until player hit a notes, but that will cause an issue on characters who has special animation like Pico's burp.

I.need.Pico.s.dick.so.bad.rn.mp4

It feels weird and might ruin some of players experience.

As a solution, I think it would be better if the vocal is muted only while the player's miss animation is playing.

And unmute it when a miss animations switched to other animations. (like an idle animation, singing animation, or special animations for the player characters)

@realClam12 realClam12 added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Mar 14, 2025
@Lasercar Lasercar linked a pull request Mar 14, 2025 that will close this issue
@AbnormalPoof AbnormalPoof reopened this Mar 14, 2025
@AbnormalPoof AbnormalPoof added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants