*.jar files in resources directory are always excluded

[ags799]

Writing a language server for a language that requires having certain jars on the classpath for compilation. Note that these jars are not needed to compile the language server itself. But the language server needs them to compile code in the served language. I was thinking that I could put these jars in the resources/ directory of my project, and that they would then make it into the language server's jar file. This works for a normal jar, but it seems that when creating a shadow jar, any kind of *.jar file in the resources directory is excluded, regardless of my includes and excludes configuration.

Shadow Version

1.2.3

Gradle Version

3.3

Expected Behavior

*.jar files in the resources/ directory are included in the shadow jar.

Actual Behavior

The *.jar files are always excluded. Their parent directories may be included, though.

[ags799]

Actually, it seems that the *.jar files are being exploded. Furthermore, after trying to override the transformer, it seems that my custom transformer never has the chance to transform these jars.

[MarcMagnin]

+1

[MarcMagnin]

I've renamed the jar extension to prevent that to happen for now.

[johnrengelman]

the problem here is that at the time Shadow runs, it doesn't know if the Jar file was provide as a dependency or included in the source files since the compiled code is being run through the processor so that transformers and relocators can modify it.

I don't see an easy way around this other than naming it something other than .jar

[ags799]

that works for me, thanks for the help @johnrengelman

[tylerbenson]

I just lost several hours to this. I think it would help if this edge case is more explicitly documented. I was about to file a new issue, but then I found this. Are the docs available somewhere in github that would allow for a PR?

[johnrengelman]

@tylerbenson - https://github.com/johnrengelman/shadow/tree/master/src/docs/asciidoc

[Goooler]

I believe this should be fixed by #1233.