You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when we are building shadow from 2 jars, and in both of them is the file with the same path (but different content), e.g. LICENSE.txt, or about.html - only one is in shadow jar, and the other one is ignored.
In SBT, both files are copied, but with amended name, e.g. in my fat jar I have files: about_jetty-http-9.2.0.v20140526.html about_jetty-io-9.2.0.v20140526.html
Both files exist as about.html in jetty-http-9.2.0.v20140526.jar and jetty-io-9.2.0.v20140526.jar
Of course this is not the case for .class files.
I'd like to implement such behavior in shadow plugin, and issue pull request. What do you think?
The text was updated successfully, but these errors were encountered:
My first thought would be that it should be implemented vi a Transformer implementation, but the API doesn't currently pass any information about which archive file the currently processed source is coming from, so you would need to be some changes there to support something like that.
I was also thinking about a Transformer, and started to fiddle with the code to have this information there (it wasn't difficult). But then I thought that this way we can handle only the files specified for the Transformer, and this should rather be default behavior.
Currently, when we are building shadow from 2 jars, and in both of them is the file with the same path (but different content), e.g. LICENSE.txt, or about.html - only one is in shadow jar, and the other one is ignored.
In SBT, both files are copied, but with amended name, e.g. in my fat jar I have files:
about_jetty-http-9.2.0.v20140526.html
about_jetty-io-9.2.0.v20140526.html
Both files exist as about.html in jetty-http-9.2.0.v20140526.jar and jetty-io-9.2.0.v20140526.jar
Of course this is not the case for .class files.
I'd like to implement such behavior in shadow plugin, and issue pull request. What do you think?
The text was updated successfully, but these errors were encountered: