Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modular_computers.generate_id uses minetest.get_password_hash in a PRNG. #14

Open
red-001 opened this issue Aug 16, 2024 · 0 comments
Open

modular_computers.generate_id uses minetest.get_password_hash in a PRNG. #14

red-001 opened this issue Aug 16, 2024 · 0 comments

Comments

@red-001
Copy link

red-001 commented Aug 16, 2024

This is an API misuse (see the discussion on luanti-org/luanti#12564), I would replacing the function so that it uses SecureRandom with a fallback to PcgRandom.

modular_computers/src/utilities.lua

Line 79 in 906f143

local hash = minetest.get_password_hash(player_name, current_time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@red-001