Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-serializable value in Redux state #711

Open
glevco opened this issue Dec 20, 2024 · 0 comments
Open

Non-serializable value in Redux state #711

glevco opened this issue Dec 20, 2024 · 0 comments
Assignees

Comments

@glevco
Copy link
Contributor

glevco commented Dec 20, 2024

After updating the wallet to support BigInt output values, a new error started appearing in the console:

image

This is more a warning than an error, this is what the linked docs says:

It is highly recommended that you only put plain serializable objects, arrays, and primitives into your store. It's technically possible to insert non-serializable items into the store, but doing so can break the ability to persist and rehydrate the contents of a store, as well as interfere with time-travel debugging.

If you are okay with things like persistence and time-travel debugging potentially not working as intended, then you are totally welcome to put non-serializable items into your Redux store. Ultimately, it's your application, and how you implement it is up to you. As with many other things about Redux, just be sure you understand what tradeoffs are involved.

Even though this error is being displayed, since apparently we don't use those features, everything seems to be working. The QA is passing.

However, we should investigate how to fix this. Ideally we can configure a custom serializer and deserializer for the Redux state, and we can use our custom BigInt parser and stringifier for that. The second option would be to simply try to disable this error.

@tuliomir tuliomir self-assigned this Dec 23, 2024
@tuliomir tuliomir mentioned this issue Jan 22, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants