Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin poetry==1.4.0 in main.yml workflow. #486

Closed
hrshdhgd opened this issue Mar 20, 2023 · 3 comments · Fixed by #516
Closed

Unpin poetry==1.4.0 in main.yml workflow. #486

hrshdhgd opened this issue Mar 20, 2023 · 3 comments · Fixed by #516

Comments

@hrshdhgd
Copy link
Collaborator

The pinning was done because of GH action failures for Windows specifically. #469. I created a blank PR #485 to test this. Once Microsoft/GitHub fixes this issue, we can remove this pinning.
@dalito
Copy link
Contributor

dalito commented Mar 20, 2023

It is an issue with invalid wheels and the strict checks that poetry uses in 1.4.1. - They plan to change that. python-poetry/poetry#7686

@dalito
Copy link
Contributor

dalito commented Apr 4, 2023

Hey @hrshdhgd, the poetry team released 1.4.2 with a fix. Now it only prints a warning.

@hrshdhgd hrshdhgd mentioned this issue Apr 4, 2023
Merged
@hrshdhgd
Copy link
Collaborator Author

hrshdhgd commented Apr 4, 2023 •
edited
Loading

Thanks for letting me know @dalito ! P.R started to close this issue: #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin poetry version in GH Actions INCATools/ontology-access-kit
2 participants
@dalito @hrshdhgd