Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-cedarling): Update sidecar to allow loading environment variables #10732

Closed
2 of 6 tasks
SafinWasi opened this issue Jan 24, 2025 · 0 comments · Fixed by #10751
Closed
2 of 6 tasks

feat(jans-cedarling): Update sidecar to allow loading environment variables #10732

SafinWasi opened this issue Jan 24, 2025 · 0 comments · Fixed by #10751
Assignees
@SafinWasi
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Milestone
1.4.0

Comments

@SafinWasi
Copy link
Contributor

Description

As per #10692, sidecar should allow loading from environment variables.

Prepare

  • Read contribution guidelines
  • Read license information

Identified code changes

  • Add environment variable loading

Test cases and code coverage

N/A

Document the changes

  • Update readme
  • Update docs
  • Update wiki
@SafinWasi SafinWasi self-assigned this Jan 24, 2025
@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Jan 24, 2025
@nynymike nynymike changed the title feat(jans-cedarling): update sidecar to allow loading environment variables feat(jans-cedarling): Update sidecar to allow loading environment variables Jan 24, 2025
@SafinWasi SafinWasi mentioned this issue Jan 27, 2025
Merged
3 tasks
@moabu moabu added this to the next-release milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SafinWasi SafinWasi

Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

feat(jans-cedarling): implement environment variable loading for sidecar JanssenProject/jans
3 participants
@SafinWasi @moabu @mo-auto