Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update genius_album to handle "features" to the info argument #21

Closed
JosiahParry opened this issue Dec 22, 2018 · 5 comments
Closed

update genius_album to handle "features" to the info argument #21

JosiahParry opened this issue Dec 22, 2018 · 5 comments

Comments

@JosiahParry
Copy link
Owner

PR #20 enabled the value "features" to the genius_url() function. This precipitates through to genius_album(). There is now a duplicated column track_title.

See below for an example:

DAMN <- genius_album(artist = "Kendrick Lamar", album = "DAMN.", info = "features")
@JosiahParry
Copy link
Owner Author

@natebarr64 if you want to try and take a stab at this go ahead.

@natebarr64
Copy link
Contributor

Thanks for the pull! I did a quick fix by removing track titles in the "features" switch of genius_url.

Bumped into another error with parsing some albums. This input:

Doris <- genius_album(artist = "Earl Sweatshirt", album = "Doris", info = "features")

leads to:

Error in mutate_impl(.data, dots) : 
  Evaluation error: Evaluation error: object 'lyric' not found.. 

Ill try to figure this out when I get a chance.

@JosiahParry
Copy link
Owner Author

This error is caused by a song with no lyrics. https://genius.com/Earl-sweatshirt-523-lyrics

The only text is "[Produced by RandomBlackDude]". The spread is causing the error.

@JosiahParry
Copy link
Owner Author

Looks like a potential work around is to bind a row to the data frame if its empty for good measure then filter out that row

@JosiahParry
Copy link
Owner Author

Fixed in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants