Skip to content

Commit 824cdf1

Browse files
authored
Merge pull request #50525 from oscardssmith/fix-generic_lu_fact-check=false
only check that values are finite in `generic_lufact` when `check=true`
2 parents 9122376 + 6ef6a0c commit 824cdf1

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

stdlib/LinearAlgebra/src/lu.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ lu!(A::AbstractMatrix, pivot::Union{RowMaximum,NoPivot,RowNonZero} = lupivottype
133133
generic_lufact!(A, pivot; check = check)
134134
function generic_lufact!(A::AbstractMatrix{T}, pivot::Union{RowMaximum,NoPivot,RowNonZero} = lupivottype(T);
135135
check::Bool = true) where {T}
136-
LAPACK.chkfinite(A)
136+
check && LAPACK.chkfinite(A)
137137
# Extract values
138138
m, n = size(A)
139139
minmn = min(m,n)

stdlib/LinearAlgebra/test/lu.jl

+7
Original file line numberDiff line numberDiff line change
@@ -464,4 +464,11 @@ end
464464
@test Matrix(F1) Matrix(F2) C
465465
end
466466

467+
@testset "matrix with Nonfinite" begin
468+
lu(fill(NaN, 2, 2), check=false)
469+
lu(fill(Inf, 2, 2), check=false)
470+
LinearAlgebra.generic_lufact!(fill(NaN, 2, 2), check=false)
471+
LinearAlgebra.generic_lufact!(fill(Inf, 2, 2), check=false)
472+
end
473+
467474
end # module TestLU

0 commit comments

Comments
 (0)