Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsume put! into push!? #12469

Closed
malmaud opened this issue Aug 5, 2015 · 6 comments
Closed

Subsume put! into push!? #12469

malmaud opened this issue Aug 5, 2015 · 6 comments
Labels
parallelism Parallel or distributed computation

Comments

@malmaud
Copy link
Contributor

malmaud commented Aug 5, 2015

Now that RemoteRefs can store an array of values, it might sense to just eliminate put! and instead push! values into RemoteRefs and Channels.

@jakebolewski jakebolewski added the parallelism Parallel or distributed computation label Aug 11, 2015
@jakebolewski
Copy link
Member

@amitmurthy I think we want to retain put! for RemoteRef's but adding push! to channels seems like a good idea.

@amitmurthy
Copy link
Contributor

The Channels API mirrors the RemoteRef API. Also RemoteRef's point to AbstractChannels. Any concrete implementation of an AbstractChannels must implement put!, take!, fetch, isready and wait. We can look at renaming put!, take! and fetch, but we should continue to keep the Channel API in sync with RemoteRef.

@jakebolewski
Copy link
Member

is there any way to push an iterable to a channel without having to splat it?

@amitmurthy
Copy link
Contributor

No.

I think I misunderstood your comment. Yes, we can add push! while retaining put!.

@malmaud
Copy link
Contributor Author

malmaud commented Oct 11, 2015

I think it would make sense to do so, since from the user's point of view a channel is just a deque with special blocking semantics.

@malmaud
Copy link
Contributor Author

malmaud commented Oct 13, 2015

Closed by #13538

@malmaud malmaud closed this as completed Oct 13, 2015
@shashi shashi mentioned this issue Feb 3, 2017
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parallelism Parallel or distributed computation
Projects
None yet
Development

No branches or pull requests

3 participants