-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some problems with library on Windows #87
Comments
So should we sync the version, or just have only the major version? I assume we need Julia 1.8.1 with this fix, right? |
In any case we should generate the import library for Going forward it'd be great the have the soversion actually match the "version number" of the package, otherwise it's an inconsistent mess.
Yes, but fixing this issue will break the ABI of the library on Windows. |
Will this fix the null pointer issue in mumps_seq and ipopt_jll on windows? Is it still something else? |
I don't think this is the culprit there, but it is a compatibility problem |
For the record, that issue is tracked by #89, and may be related to the confusion between the libraries available on Windows. |
There are currently two orthogonal issues with the library on Windows (spotted in jump-dev/Ipopt.jl#327 (comment)):
src/Make.inc
is stalling:libblastrampoline/src/Make.inc
Lines 26 to 28 in b829b0e
libblastrampoline/src/Makefile
Lines 45 to 46 in b829b0e
$@
, which isLIB_FULL_VERSION
, which is a bad idea because it means the ABI is broken in every single version (well, every single version where the soversion is actually bumped, see point above)An overall solution is probably to stop generating the library with the full name on Windows, or at least generating the import library for
LIB_MAJOR_VERSION
instead ofLIB_FULL_VERSION
.It remains the problem of actually remembering to update the soversion in
src/Make.inc
when doing a new release.CC: @ViralBShah
The text was updated successfully, but these errors were encountered: