Skip to content

Commit e506636

Browse files
committed
perfdata added to file open list
along with a group that includes it and moving out to a separate function again
1 parent 9db22ee commit e506636

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/mainwindow.cpp

+10-4
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,7 @@ MainWindow::MainWindow(QWidget* parent)
177177
auto openNewWindow = new QAction(QIcon::fromTheme(QStringLiteral("document-open")), tr("Open in new window"), this);
178178
openNewWindow->setShortcut(Qt::Key_O | Qt::ControlModifier | Qt::ShiftModifier);
179179
connect(openNewWindow, &QAction::triggered, this, [this] {
180-
const auto fileName = QFileDialog::getOpenFileName(this, tr("Open File"), QDir::currentPath(),
181-
tr("Data Files (perf*.data perf.data.*);;All Files (*)"));
180+
const auto fileName = getOpenDataFileName();
182181
if (!fileName.isEmpty())
183182
openInNewWindow(fileName);
184183
});
@@ -279,10 +278,17 @@ void MainWindow::closeEvent(QCloseEvent* event)
279278
QMainWindow::closeEvent(event);
280279
}
281280

281+
QString MainWindow::getOpenDataFileName()
282+
{
283+
const QString filter = tr("Hotspot data Files (perf*.data perf.data.* *.perfparser);;"
284+
"Linux Perf Files (perf*.data perf.data.*);;"
285+
"Perfparser Files (*.perfparser);;All Files (*)");
286+
return QFileDialog::getOpenFileName(this, tr("Open File"), QDir::currentPath(), filter);
287+
}
288+
282289
void MainWindow::onOpenFileButtonClicked()
283290
{
284-
const auto fileName = QFileDialog::getOpenFileName(this, tr("Open File"), QDir::currentPath(),
285-
tr("Data Files (perf*.data perf.data.*);;All Files (*)"));
291+
const auto fileName = getOpenDataFileName();
286292
if (fileName.isEmpty()) {
287293
return;
288294
}

src/mainwindow.h

+1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ public slots:
6868
void openFile(const QString& path, bool isReload);
6969
void closeEvent(QCloseEvent* event) override;
7070
void setupCodeNavigationMenu();
71+
QString getOpenDataFileName();
7172

7273
QScopedPointer<Ui::MainWindow> ui;
7374
PerfParser* m_parser;

0 commit comments

Comments
 (0)