Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report SwiftLint warnings on warnings/errors on pull requests #119

Open
the-freshlord opened this issue Sep 15, 2017 · 2 comments
Open

Report SwiftLint warnings on warnings/errors on pull requests #119

the-freshlord opened this issue Sep 15, 2017 · 2 comments

Comments

@the-freshlord
Copy link

Hello,

Can we add a feature to the Package-Builder for reporting warnings or errors from SwiftLint on pull requests? I was thinking Danger could be integrated into the project for handling this. Thanks.

@the-freshlord the-freshlord changed the title Report SwiftLint warnings or errors on pull requests Report SwiftLint warnings on warnings/errors on pull requests Sep 15, 2017
@christiancompton
Copy link
Contributor

@eman6576 Can you further explain how the current swiftlint digestion is inadequate in this context?

@the-freshlord
Copy link
Author

the-freshlord commented Oct 2, 2017

When the swiftlint step runs for a build in TravisCI for instance, it will report any warnings or errors on the logs of the build. I was wondering if there was a way to take what was displayed in the build log and post as a comment on pull requests? Similar to what Codecov does for pull requests. That way you wouldn't need to look at the build logs to see what lint warnings or errors where found. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants