Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radicale rights file and case-sensitive issue #1118

Closed
vijaysar opened this issue Nov 2, 2020 · 4 comments
Closed

radicale rights file and case-sensitive issue #1118

vijaysar opened this issue Nov 2, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@vijaysar
Copy link

vijaysar commented Nov 2, 2020

Looks like the rights file regex is compared case-sensitive by default. We have users whose URL is http://calurl/user/user.ics but the user is allows to login with credentials of User or usEr without any case checking. Is it possible to support this in rights file? Or in the code you could check regex match with

re.IGNORECASE

flag. The later seems like a good long term option.

@GuruSR
Copy link

GuruSR commented Dec 8, 2024

Suggestion: Add a flatten (all lowercase) or raise (all uppercase) to the username at login, ignoring case is fine for just all lowercase, but in some instances having the ability to do 2 of the same ID can be useful: USER would be easier to read in a list than user, especially with logins with i and l's in them, their uppercase counterparts are typically easier to read when looking for something manually.

@pbiering
Copy link
Collaborator

pbiering commented Dec 9, 2024

There is already a option converting usernames to lower case, can be enabled if required

https://github.com/Kozea/Radicale/blob/master/DOCUMENTATION.md#lc_username

Does this not already help?

@pbiering pbiering added the need:reporter feedback feedback from reporter required label Dec 9, 2024
@GuruSR
Copy link

GuruSR commented Dec 10, 2024

No, there was no issue, was just a suggestion to offer lowercase and uppercase as 2 options, not just lowercase.

@pbiering pbiering added this to the 3.3.2 milestone Dec 10, 2024
@pbiering pbiering removed the need:reporter feedback feedback from reporter required label Dec 10, 2024
@pbiering pbiering self-assigned this Dec 10, 2024
@pbiering
Copy link
Collaborator

fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants