Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font file gets modified without changes #12

Closed
hawckins opened this issue Jan 29, 2020 · 2 comments
Closed

Font file gets modified without changes #12

hawckins opened this issue Jan 29, 2020 · 2 comments

Comments

@hawckins
Copy link
Contributor

Everything works great but, version control always shows webfont file modified, and we haven't add/delete any icons in our source directory. How do I stop modifying this file all the time except there are changes.

The issue I found is in exports.generatedFontFiles() method in util/util.js, brace expression is not working in glob.sync, so glob.sync is not returning an array of files instead it returns empty [ ] array.

will you please let me know how soon you can fix this issue? waiting for your response... If you can add me as contributor to this project, I can fix too.
@L2jLiga
Copy link
Owner

L2jLiga commented Jan 29, 2020

Hi there!
Feel free to fork and send PR :)

@hawckins
Copy link
Contributor Author

Hi there!
Feel free to fork and send PR :)

I have created an PR will you please verify and merge?

@L2jLiga L2jLiga closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hawckins @L2jLiga