-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation errors on Visual Studio with C++20 standard #122
Comments
I will take a look. Is this on the latest visual studio version? I had some trouble in the past with some breaking changes in C++20 and U8 strings, so this might be related to that. |
We are using the
|
Are you building with the Units CMAKE or just including the code in your library? For other compilers you would need |
I am using this via |
Yeah it should be, if you want to check something try adding those flags to your project and see if it compiles. I might have put them in the wrong spot, or something that doesn't propagate under add_subdirectory |
I can confirm, this is fixed by #125. Thanks a lot for the quick response! |
Getting these errors:
I tried to understand what is wrong, but failed for now. I first thought it was a problem with using
const char *
in a map, but one of the errors (line 2400) happens for a map without strings, so that can't be it?Versions:
Complete log:
The text was updated successfully, but these errors were encountered: