fixes #1824

Author: tabacitu

CHANGELOG.md

@@ -20,6 +20,11 @@ All Notable changes to `Backpack CRUD` will be documented in this file
 - Nothing
 -----------
 
+## [3.6.17] - 2019-05-07
+
+### Fixed
+- fixes #1824 - inside the ListEntries operation, ```visibleInModal``` did not work for columns that were NOT ```visibleInTable```;
+
 ## [3.6.16] - 2019-04-25
 
 ### Fixed

src/resources/views/inc/datatables_logic.blade.php

@@ -55,10 +55,12 @@ functionsToRunOnDataTablesDrawEvent: [],
                     }
                 } ),
                 renderer: function ( api, rowIdx, columns ) {
+
                   var data = $.map( columns, function ( col, i ) {
+                      var columnHeading = crud.table.columns().header()[col.columnIndex];
                       var allColumnHeaders = $("#crudTable thead>tr>th");
 
-                      if ($(allColumnHeaders[col.columnIndex]).attr('data-visible-in-modal') == 'false') {
+                      if ($(columnHeading).attr('data-visible-in-modal') == 'false') {
                         return '';
                       }
 

src/resources/views/list.blade.php

@@ -52,9 +52,9 @@
                   <th
                     data-orderable="{{ var_export($column['orderable'], true) }}"
                     data-priority="{{ $column['priority'] }}"
-                    data-visible-in-modal="{{ (isset($column['visibleInModal']) && $column['visibleInModal'] == false) ? 'false' : 'true' }}"
-                    data-visible="{{ !isset($column['visibleInTable']) ? 'true' : (($column['visibleInTable'] == false) ? 'false' : 'true') }}"
-                    data-visible-in-export="{{ (isset($column['visibleInExport']) && $column['visibleInExport'] == false) ? 'false' : 'true' }}"
+                    data-visible="{{ var_export($column['visibleInTable'] ?? true) }}"
+                    data-visible-in-modal="{{ var_export($column['visibleInModal'] ?? true) }}"
+                    data-visible-in-export="{{ var_export($column['visibleInExport'] ?? true) }}"
                     >
                     {!! $column['label'] !!}
                   </th>