Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is setFromDB method will be kept in the future? #45

Closed
welcoMattic opened this issue Jun 23, 2016 · 2 comments
Closed

Is setFromDB method will be kept in the future? #45

welcoMattic opened this issue Jun 23, 2016 · 2 comments
Milestone

Comments

@welcoMattic
Copy link
Contributor

I've some issues with setFromDB method, specially on edit views with relations fields.
I'm ok to try to fix them, but I want to know if the setFromDB method will be kept in the future, or if you want to delete it, in benefit to manually addField methods

@tabacitu
Copy link
Member

Hi Mathieu,

I say the setFromDB method is here to stay. Sure, we're writing a lot of things manually now, but in the future, I can easily see setFromDB becoming a powerhouse, with smart defaults, figuring out the Model after the foreign key and appropriately setting the column and field types, etc. In time, I see two big uses for this method:

  • for simple CRUD panels, setFromDB should be all you need;
  • for complex CRUD panels, you could change the way you approach CRUD panels: have everything set automatically by setFromDB, then just change a few columns/fields it got wrong;

I think that's feasible, on the long term. So yeah, if you can fix some of the issues, please do!

Cheers!

@welcoMattic
Copy link
Contributor Author

Ref. #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants