Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column type: image #64

Closed
tabacitu opened this issue Jul 21, 2016 · 4 comments
Closed

Column type: image #64

tabacitu opened this issue Jul 21, 2016 · 4 comments

Comments

@tabacitu
Copy link
Member

An image thumbnail colum should be easy to do.

Allow developer to customize:

  • max width
  • max height
    (Aspect ratio should be kept)

Click on image should open image in a new tab.

We could make thumbs using Glide: https://packagist.org/packages/league/glide

Any alternatives in mind?

@OSDDQD
Copy link

OSDDQD commented Jul 22, 2016

Why not Intervention Image?

@tabacitu
Copy link
Member Author

Hmm... I may be mistaken, but I think they do separate things:

  • You can use Intervention to create thumbnails and store them in your filesystem;
  • You can use Glide for on-demand image processing;

In fact, I believe Glide uses Intervention to do all its processing. It's just an API for it, in the form or URL parameters.

@OSDDQD
Copy link

OSDDQD commented Jul 25, 2016

@tabacitu yeah, my fault.
I read more carefully the documentation package, very cool. Waiting for the new version. My implementation of file fields is not very flexible, have a lot to configure the model class.

  • field name
  • type (image or file)
  • storage dir (or Storage disk)
  • size & weight
  • field and size for thumb

@tabacitu
Copy link
Member Author

Done! Added in f405175. Documentation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants