Typo in the physical_optics_propagation function

[Lupatran]

Problem

Hi!

I found a small issue in the code of zospy/analyses/physicaloptics.py.
At lines 334-335, I noticed this:

elif isinstance(start_surface, int):
        analysis.Settings.StartSurface.SetSurfaceNumber(1)

It seems like it should be:

elif isinstance(start_surface, int):
        analysis.Settings.StartSurface.SetSurfaceNumber(start_surface)

I'm not a great GitHub user, so please let me know if there's a better way to report issues like this.

Thanks ! :)

What version of ZOSPy are you running?

1.3.0

What version of OpticStudio are you running?

not concerned

Which operating system do you use?

not concerned

In which environment do you use ZOSPy?

• Plain Pythons scripts (not in Spyder)
• Jupyter notebooks
• Spyder

In which connection modes does the problem occur?

• Extension mode
• Standalone mode

Example code

No response

Output

No response

Additional information

No response

[LucVV]

Hi @Lupatran,

This indeed seems to be implemented wrong and should be fixed. Can you create a small pull request that fixes it?

[LucVV]

@Lupatran version 1.3.1 in which you fix is implemented has just been released!