Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small refactor: executeTerminalCommand #29

Closed
VladimirFokow opened this issue Oct 25, 2024 · 1 comment
Closed

small refactor: executeTerminalCommand #29

VladimirFokow opened this issue Oct 25, 2024 · 1 comment
Assignees
@VladimirFokow
Labels
before v1.0.0

Comments

@VladimirFokow
Copy link
Collaborator

VladimirFokow commented Oct 25, 2024 •
edited
Loading

refactor this:
https://github.com/bhoov/manim-notebook/blob/4543f93822ccada625ccb1040e884629fd6599d4/src/previewCode.ts#L5-L7

instead of only there - add \x0C and \x1b in the executeTerminalCommand function itself
(we can add args to this function which command whether to add these symbols or not)
@VladimirFokow VladimirFokow self-assigned this Oct 28, 2024
@VladimirFokow
Copy link
Collaborator Author

The PR #81 has made this issue obsolete, so closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladimirFokow VladimirFokow

Labels
before v1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VladimirFokow