Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeListViewItem does not mark KeyEvents as handled #3520

Closed
KennethWhite opened this issue Apr 9, 2024 · 0 comments
Closed

TreeListViewItem does not mark KeyEvents as handled #3520

KennethWhite opened this issue Apr 9, 2024 · 0 comments
Labels
Milestone

Comments

@KennethWhite
Copy link
Contributor

Bug explanation

Description:
In #3333 in the new TreeListViewItem.cs there is an OnKeyDown handler for collapsing/expanding items, however, the handler does not mark the KeyEventArgs as handled.

This leads to unexpected behavior where the event can be handled when this TreeListView is in focus, and then also handled by other event handlers for the arrow keys.

Expected Behavior:
The OnKeyDown handler marks the KeyEventArgs as handled.

https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/2a085a2f0381046a64c074750f9381147d98a4f8/MaterialDesignThemes.Wpf/TreeListViewItem.cs#L177C4-L199C6

Version

5.0.0-ci472

@KennethWhite KennethWhite added bug evaluation required Items is pending review or evaluation by the team labels Apr 9, 2024
@Keboo Keboo added this to the 5.1.0 milestone Apr 10, 2024
@Keboo Keboo removed the evaluation required Items is pending review or evaluation by the team label Apr 10, 2024
@Keboo Keboo closed this as completed Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants