Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug|missing feature] Flipper prevents content from changing colors on switching palette #694

Closed
Insire opened this issue Apr 21, 2017 · 8 comments · Fixed by #3431
Closed
Labels
bug Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/
Milestone

Comments

@Insire
Copy link
Contributor

Insire commented Apr 21, 2017

Reproduction:

  • start MaterialDesignDemo app from the Demos folder in the solution
  • switch to Cards view and check color of the Flipper and its child ColorZone being violet and lime accent
  • then change palette in palette view to a different color for accent and primary
  • switch back to Cards view

Expectation:

  • Flipper and its child ColorZone have the selected colors

Result:

  • Flipper and its child ColorZone still have the old colors (violet and lime)

The issue can be verified in my own project too

  • start the app
  • click the globe in the window header
  • view with flipper opens
  • click brush in window header
  • change color in the opening view for primary and accent
  • click globe again
  • flipper still has the same color
@Insire
Copy link
Contributor Author

Insire commented Apr 22, 2017

Here are some more information on the problem.

I did some looking around on google, and from my limited understanding of the matter, it seems that there is no easy universal way to update dynamic resources in an animation. The common approach seems to be to handcode the original animation and additionally handcode the animation for the color change in code behind. Obviously thats not a viable approach for a control library.

Does anyone have a better insight on the topic? Did i miss something? This is a really cool control and it would be sad if it would have such limited functionality.

@Insire Insire changed the title [Bug|missing feature] Flipper prevents ColorZone from changing colors on switching palette [Bug|missing feature] Flipper prevents content from changing colors on switching palette Apr 22, 2017
@Aangbaeck
Copy link

Aangbaeck commented Sep 18, 2017

I'm missing this badly as well.

@Tide
Copy link
Contributor

Tide commented Dec 18, 2017

This bug is still present. Has anyone found a workaround/fix?

@ChrisLawford
Copy link

I would love to know if anyone has a workaround for this aswell. I was wondering if there is anyway to get the theme colour from the Palette selector but had no luck.

@Keboo Keboo added this to the 2.5.0 milestone Jul 26, 2018
@Keboo
Copy link
Member

Keboo commented Jul 26, 2018

Flagging this for review with the 2.5.0 release. This just means I will spend some time digging into the cause of the issue (maybe fixing depending on what it is) prior to releasing 2.5.0.

@Keboo Keboo added the Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ label Oct 2, 2018
@Keboo Keboo removed this from the 2.5.0 milestone Oct 14, 2018
@Keboo Keboo added the bug label May 10, 2019
@sebaJoSt
Copy link

I think this is still open. I tried to implement the flipper in my own app, but the colors are not updated when switching from light to dark mode and vice versa. The latest MaterialDesignDemo app shows the same behaviour.

@bee-eater
Copy link

Push

@ElieTaillard
Copy link
Member

ElieTaillard commented Jun 1, 2022

I'm going to check that

EDIT:
I will create a new issue cause the flipper seems broken in the last version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants