Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monokai button focus color is too similar to checkbox enabled border color #48855

Closed
roblourens opened this issue Apr 27, 2018 · 6 comments
Closed

Monokai button focus color is too similar to checkbox enabled border color #48855

roblourens opened this issue Apr 27, 2018 · 6 comments
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s) themes Color theme issues
Milestone
Backlog

Comments

@roblourens
Copy link
Member

Checkbox toggled on
image

Checkbox focused
image

Dark+ has a brighter color for "toggled on" and dimmer for "focused"
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug themes Color theme issues labels Apr 27, 2018
@roblourens roblourens added this to the May 2018 milestone Apr 27, 2018
@roblourens roblourens self-assigned this Apr 27, 2018
@roblourens roblourens changed the title Monokai button focus color is same color as checkbox enabled border Monokai button focus color is too similar to checkbox enabled border color Apr 27, 2018
@mick-io
Copy link

mick-io commented Apr 27, 2018

I can tackle this.

@roblourens
Copy link
Member Author

Sure! 🎉

@mick-io mick-io mentioned this issue Apr 28, 2018
Closed
@mick-io
Copy link

mick-io commented Apr 28, 2018

Pull request submitted. Thanks for the opportunity.
#48867

@Tyriar
Copy link
Member

Tyriar commented Apr 30, 2018

After discussion in #48867 we think that the right solution to this is by adding a new theme key inputOption.activeBackground and support it in built-in themes that make sense.

@roblourens roblourens modified the milestones: May 2018, Backlog May 30, 2018
@roblourens
Copy link
Member Author

I think this is waiting on general icon work in #8017

@roblourens roblourens mentioned this issue Jun 24, 2018
Closed
@roblourens
Copy link
Member Author

Closing as dupe of #8017

@roblourens roblourens added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Jun 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s) themes Color theme issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @mick-io