Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Emmet doesnt stop some of the Emmet commands from showing up #58600

Closed
WORMSS opened this issue Sep 13, 2018 · 13 comments · Fixed by #110891
Closed

Disabling Emmet doesnt stop some of the Emmet commands from showing up #58600

WORMSS opened this issue Sep 13, 2018 · 13 comments · Fixed by #110891
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues

Comments

@WORMSS
Copy link

WORMSS commented Sep 13, 2018

I would like to disable Emmet.. And I mean, Disable ALL of it..
As if it's not in VS code at all..

It just pollutes the commands list.

image

If Emmet was an extension, I could just uninstall it.. but it seems to be built in and not able to remove it.

@vscodebot
Copy link

vscodebot bot commented Sep 13, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the emmet Emmet related issues label Sep 13, 2018
@lannonbr
Copy link
Contributor

@WORMSS, If you open the extensions tab and type @Builtin to the search box, Emmet is a built in extension that will appear and you can disable it in a specific workspace or entirely:

screen shot 2018-09-13 at 8 42 01 am

@WORMSS
Copy link
Author

WORMSS commented Sep 13, 2018

Ahh, thank you @lannonbr I had no idea you could list the built in..

The irony, now that I know extensions can show extra stuff. I have noticed the ... dots to list everything.. I am sorry I feel so dumb..

image

@WORMSS WORMSS closed this as completed Sep 13, 2018
@WORMSS
Copy link
Author

WORMSS commented Sep 13, 2018

@lannonbr it seems it doesn't disable it enough..
2 commands are still added.. And if you try to call them, they throw an error..

image

image

image

@WORMSS WORMSS reopened this Sep 13, 2018
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Sep 13, 2018
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Sep 13, 2018
@ramya-rao-a ramya-rao-a changed the title Disable Emmet Disabling Emmet doesnt stop some of the Emmet commands from showing up Sep 13, 2018
@ramya-rao-a
Copy link
Contributor

@octref The 2 commands in
#58600 (comment) are contributed by the core and not the built-in extensions.

Since extensions have no way of knowing the language under the cursor, we use the core command Emmet: Expand Abbreviation to figure out the language and then call the corresponding command from the built-in extension. This was done to avoid regression when we moved the Emmet features out to an extension.

The way to fix this bug is for the core to somehow figure out that the built-in extension is disabled, and then disable the above 2 commands

@ramya-rao-a ramya-rao-a assigned octref and unassigned ramya-rao-a Nov 19, 2018
@ghost
Copy link

ghost commented Jun 24, 2020

Why is Emmet even built-in anyway? I doubt even 10% of VS Code users use it.

@rzhao271
Copy link
Contributor

Verifier:

  1. Disable the Emmet extension
  2. Open the command palette and search for Emmet commands

Ensure no Emmet commands show in the results

@WORMSS
Copy link
Author

WORMSS commented Nov 19, 2020

image

image

@rzhao271

@rzhao271
Copy link
Contributor

rzhao271 commented Nov 19, 2020

Lol @WORMSS you're too fast. The issue is currently labelled as "unreleased".
Please wait for the next Insiders release tomorrow, after the bot labels the issue as "insiders-released".

@rzhao271
Copy link
Contributor

rzhao271 commented Nov 20, 2020

Is the issue resolved for you now? You'll need to download the Insiders version to verify the fix: https://code.visualstudio.com/insiders/

chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@rzhao271
Copy link
Contributor

rzhao271 commented Nov 23, 2020

Seems like moving the Expand Abbreviation command from workbench to Emmet broke keybinding precedence, so I'll have to revert this change for now.

@rzhao271 rzhao271 reopened this Nov 23, 2020
@rzhao271 rzhao271 reopened this Nov 23, 2020
@rzhao271 rzhao271 modified the milestones: January 2021, Backlog Dec 29, 2020
@cesarvarela
Copy link

I think vscode has reached a point were removing features is better than adding them. Emmet being one of them 😄

@rzhao271
Copy link
Contributor

rzhao271 commented Dec 6, 2022

Closing in favour of #110899

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@rzhao271 rzhao271 removed this from the Backlog milestone Jan 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@cesarvarela @WORMSS @lannonbr @octref @rzhao271 @ramya-rao-a and others