Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with server config forge 1.18.2 #193

Closed
itsdinkd opened this issue Jun 16, 2022 · 7 comments
Closed

issue with server config forge 1.18.2 #193

itsdinkd opened this issue Jun 16, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@itsdinkd
Copy link

[16Jun2022 16:29:12.001] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Configuration file G:\mc\Instances\AQM3 1.18.2\saves\New World (1)\serverconfig\littlelogistics-server.toml is not correct. Correcting
[16Jun2022 16:29:12.001] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key vessel.general.vesselInvuln was corrected from [create.mechanical_saw, create.mechanical_drill] to its default, [create.mechanical_saw, create.mechanical_drill]. 
[16Jun2022 16:29:12.001] [Server thread/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key train.general.trainInvuln was corrected from [create.mechanical_saw, create.mechanical_drill] to its default, [create.mechanical_saw, create.mechanical_drill]. 

makes zero sense as its literally correcting its default value, which is also wrong (the name space is incorrect)

@MuradAkh
Copy link
Owner

MuradAkh commented Jun 17, 2022

Could you please explain what you mean by "the namespace is incorrect"

I am a bit confused by the error message, not sure why it's triggered or what it means.

The string values in the list are correct, they are the IDs/msg names of DamageSources related to those create actors, not IDs of blocks or entities

@MuradAkh MuradAkh added the bug Something isn't working label Jun 20, 2022
@MuradAkh
Copy link
Owner

Had a better look at this, the reason for this issue is that we aren't calling the right define method in the config for lists. Will be fixed in the next release.

@itsdinkd
Copy link
Author

Had a better look at this, the reason for this issue is that we aren't calling the right define method in the config for lists. Will be fixed in the next release.

in the default config you wrote create.mechanical_saw where it should be create:mechanical_saw.

You cannot change it in the file because if you do the config gets reset again and will write in "create.mechanical.blade"

The problem is you used a "." after the modid, create, instead of a ":"

@itsdinkd
Copy link
Author

itsdinkd commented Aug 14, 2022

The commit is still incorrect.

List.of("create.mechanical_saw"
 ...

Should be

List.of("create:mechanical_saw"
 ...

@MuradAkh
Copy link
Owner

MuradAkh commented Aug 15, 2022

@itsdinkd no this is in fact correct. This is a damage source name not an entity ID or anything. Damage source "names" were defined with a dot by create, unless this changed in 0.5.

The correction issue should be fixed in 1.2.6, it was unrelated to the namespace and was because validation was because config lists were defined incorrectly. If you can reproduce this issue in 1.2.6 please let me know

@itsdinkd
Copy link
Author

Ah I see. Thank you for the clarification and the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants