Automatic switching from light to dark mode on macOS has bugs

[LenaWil]

macOS has the possibility to automatically switch to dark mode when the sun goes under.

This does not work correctly with Gittyup.

[Murmele]

@LenaWil currently we don't have a macos developer. Shall this change happen only at restart or when the os chabges to darkmode Gittyup changes too?

[LenaWil]

When the sun goes under and the theme of macOS goes to dark, and Gittyup is open at the time of the change, Gittyup changes too and the glitch happens.

I tried to reproduce it both in Gnome on Ubuntu and on Windows 11 by changing the theme while it was open there, but the same glitch doesn’t happen there, because Gittyup stayed the same theme while opened even when set to system.

[Murmele]

Thank you. We will check out to get it work also with Gnome so this might fix then also your problem

[LenaWil]

Thank you. We will check out to get it work also with Gnome so this might fix then also your problem

Okay, just to be clear, it did not happen with gnome or Windows because there it stays the same theme.

[Murmele]

Yes but if we get it work there we might also fix the issue with MacOS. Do you have screenshots how it looks in the lightmode? What happens if you start Gittyup at night, does it look same?

[LenaWil]

If I start up Gitty in light mode:

And this is what dark mode looks like normally:

The inverse glitch: (So switching from dark to light, aka sun rise, while open)

[Murmele]

Thanks for the screenshot. I will have a look into it

[Murmele]

Just for documentation:
Used in Application.cpp

  // Initialize theme.
  mTheme.reset(Theme::create(parser.value("theme")));
  setStyle(mTheme->style());
  setStyleSheet(mTheme->styleSheet());

https://successfulsoftware.net/2021/03/31/how-to-add-a-dark-theme-to-your-qt-application/

void MainWindow::changeEvent( QEvent* e )
{
#ifdef Q_OS_MACX
    if ( e->type() == QEvent::PaletteChange )
    {
        // update icons to appropriate theme
        ...
    }
#endif
    QMainWindow::changeEvent( e );
}

[Murmele]

@LenaWil If you restart Gittyup when this problem occurs, are the colors correct?

[LenaWil]

Yes.

[RokeJulianLockhart]

Same on KDE Plasma.