Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should add variables needed to calculate NBP into bc_out data structure #1320

Open
ckoven opened this issue Jan 29, 2025 · 1 comment
Open

Comments

@ckoven
Copy link
Contributor

ckoven commented Jan 29, 2025

In order for the host models to be able to calculate NBP, we need to pass to the host models all of the carbon fluxes leaving the FATES system. Currently we aren't passing fire emissions, instantaneous carbon losses to the atmosphere during land use change (conceptually overlapping with fire), grazing losses, and possibly others to come in the future.

@rosiealice has added some of the speciated fire emissions in NorESMhub#7. This is also related: ESCOMP/CTSM#1045.

We have an old issue on this point in #163. Since that is so old, I'll bring it up here again via this new issue so that it is closer to the top of the queue, as it is becoming more salient now.

@ckoven
Copy link
Contributor Author

ckoven commented Mar 7, 2025

Update: I've done some work to include these and I believe I now have NBP and related variables working. Will issue PRs once I confirm correct behavior under a new spinup case.

FATES branch: ckoven/fates@twostream-restart-bugfixes-shijiefix...ckoven:fates:nbp_diagnostics
ELM commit: ckoven/E3SM@012f9c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant