Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and code bug #135

Closed
oiabtt opened this issue Jan 24, 2024 · 2 comments · Fixed by #136
Closed

Docs and code bug #135

oiabtt opened this issue Jan 24, 2024 · 2 comments · Fixed by #136

Comments

@oiabtt
Copy link

oiabtt commented Jan 24, 2024

in docs(https://miditok.readthedocs.io/en/latest/examples.html), you pass list

midi_paths = list(Path("path", "to", "dataset").glob("**/*.mid"))
augment_midi_dataset(
    midi_paths,

but in code, it's different


:param data_path: root path to the folder containing tokenized json files.

data_path: Path | str,

and ".midi" is ignored

files_paths = list(Path(data_path).glob("**/*.mid"))

@Natooz
Copy link
Owner

Natooz commented Jan 24, 2024

Hi, thank you for the catch!
Indeed this should be fixed! For the file extensions we can use miditok.constants.MIDI_FILES_EXTENSIONS
Do you want to make the code contribution or should I do it?

@oiabtt
Copy link
Author

oiabtt commented Jan 24, 2024

Hi, thank you for the catch! Indeed this should be fixed! For the file extensions we can use miditok.constants.MIDI_FILES_EXTENSIONS Do you want to make the code contribution or should I do it?

you could do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants