Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tests for SimulateTransactions method #2431

Open
AnkushinDaniil opened this issue Feb 6, 2025 · 2 comments
Open

Implement tests for SimulateTransactions method #2431

AnkushinDaniil opened this issue Feb 6, 2025 · 2 comments
Labels
Test Any feature which requires more tests

Comments

@AnkushinDaniil
Copy link
Contributor

Problem

Now we only cover "empty data" and "error" cases in TestSimulateTransactions.

Current situation

There are 2 private function tests after #2397 in simulation_pkg_test.go

TODO

These private function tests need to be replaced by tests of public SimulateTransactions with non-empty data cases.

Tip

Data from clients/feeder/testdata may help.
@AnkushinDaniil AnkushinDaniil added go Test Any feature which requires more tests labels Feb 6, 2025
@TheRanomial
Copy link

Can I handle this task?

@rodrigo-pino rodrigo-pino removed the go label Feb 12, 2025
@demola234
Copy link

Could I be assigned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test Any feature which requires more tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rodrigo-pino @demola234 @AnkushinDaniil @TheRanomial