Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ordered events key and values to actuall felts instead of pointers to felts #2585

Open
rodrigo-pino opened this issue Mar 1, 2025 · 0 comments

Comments

@rodrigo-pino
Copy link
Contributor

As the tile says, in vm/trace.go, the struct definition:

type OrderedEvent struct {
	Order uint64       `json:"order"`
	From  *felt.Felt   `json:"from_address,omitempty"`
	Keys  []*felt.Felt `json:"keys"`
	Data  []*felt.Felt `json:"data"`
}

Has the fields Key and Data as pointers of felts. Ideally they are directly array of felts and all the changes directly with them are applied.

End result

type OrderedEvent struct {
	Order uint64      `json:"order"`
	From  *felt.Felt  `json:"from_address,omitempty"`
	Keys  []felt.Felt `json:"keys"`
	Data  []felt.Felt `json:"data"`
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant