From 8bf1e03ced451f04af7abe3e9591b8a145f1ba25 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 12:41:04 +0530 Subject: [PATCH 01/10] Update pull_request_template.md Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 33 ++++++-------------------------- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index cde342f..55743fb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,30 +1,9 @@ # Description +Include a descripton of what this change does. +Type(Bug/Feature/Improvements) +Asana Link - +Design Doc Link - -Please include a summary of the changes and the related issue. -Please also include relevant motivation and context. Mention dependency if there are. +## Tests +Mention steps to reproduce the fix or run tests for the changes. - -Fixes # (issue) - -## Type of change - -Please delete options that are not relevant. - -- [ ] Improvements -- [ ] Bug fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - -## Changes proposed in this PR - -## How Has This Been Tested? - -## Checklist: - -- [ ] My code follows the style guidelines of this project -- [ ] I have performed a self-review of my code -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have made corresponding changes to the documentation -- [ ] I have added tests that prove my fix is effective or that my feature works -- [ ] New and existing unit tests pass locally with my changes -- [ ] Any dependent changes have been merged and published in downstream modules From 7d332c7955b6d07eabec2e10f0357b1751306712 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 12:43:24 +0530 Subject: [PATCH 02/10] Update pull_request_template.md Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 55743fb..2da2fd0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,10 @@ # Description Include a descripton of what this change does. -Type(Bug/Feature/Improvements) + +Type - Bug/Feature/Improvements + Asana Link - + Design Doc Link - ## Tests From 0ea5b116cca86db8c6f440dadf020ba39501a652 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 12:50:45 +0530 Subject: [PATCH 03/10] Update pull_request_template.md Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2da2fd0..f9c1047 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,5 +8,8 @@ Asana Link - Design Doc Link - ## Tests -Mention steps to reproduce the fix or run tests for the changes. +- [ ] Existing tests cover this scenario too + +- [ ] New tests added for this change + Mention steps to reproduce the fix or run tests for the changes. From 0e32dcae5c2c3c1fde999cf391d9110dbcab0a67 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 12:57:27 +0530 Subject: [PATCH 04/10] Update pull_request_template.md Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f9c1047..cf48846 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,7 +3,7 @@ Include a descripton of what this change does. Type - Bug/Feature/Improvements -Asana Link - +Attach PR link to Asana Design Doc Link - From d9c5a21d205ed06c00b09ffea2b6e2b900973ad1 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 13:21:42 +0530 Subject: [PATCH 05/10] Update pull_request_template.md Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index cf48846..283892c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,5 +11,6 @@ Design Doc Link - - [ ] Existing tests cover this scenario too - [ ] New tests added for this change - Mention steps to reproduce the fix or run tests for the changes. + +Mention steps to reproduce the fix or run tests for the changes. From 21ca83a91abf9461b9c73d7f04797446086be691 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 14:35:21 +0530 Subject: [PATCH 06/10] Update .github/pull_request_template.md Co-authored-by: NEAdmin <109339544+nimbleedge-dev@users.noreply.github.com> Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 283892c..c190996 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,7 @@ # Description Include a descripton of what this change does. -Type - Bug/Feature/Improvements +Type - Bug/New Feature/Improvements Attach PR link to Asana From faecfc9112b391838bf3bb1f241c742d50a21893 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 14:35:31 +0530 Subject: [PATCH 07/10] Update .github/pull_request_template.md Co-authored-by: NEAdmin <109339544+nimbleedge-dev@users.noreply.github.com> Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c190996..88df224 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,7 +3,7 @@ Include a descripton of what this change does. Type - Bug/New Feature/Improvements -Attach PR link to Asana +[ ] Attached PR link on the Asana task Design Doc Link - From dd0872848e000315e70952ea6917efcba71f2b4c Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 14:35:45 +0530 Subject: [PATCH 08/10] Update .github/pull_request_template.md Co-authored-by: NEAdmin <109339544+nimbleedge-dev@users.noreply.github.com> Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 88df224..1e970eb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ Type - Bug/New Feature/Improvements Design Doc Link - ## Tests -- [ ] Existing tests cover this scenario too +- [ ] Are there existing tests to validate changes introduced in the PR? - [ ] New tests added for this change From 59aa17fceba3ea106bc829bab1ea023b5abeeedb Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 14:35:52 +0530 Subject: [PATCH 09/10] Update .github/pull_request_template.md Co-authored-by: NEAdmin <109339544+nimbleedge-dev@users.noreply.github.com> Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1e970eb..3bcb883 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,7 +10,7 @@ Design Doc Link - ## Tests - [ ] Are there existing tests to validate changes introduced in the PR? -- [ ] New tests added for this change +- [ ] New tests added for changes in the PR Mention steps to reproduce the fix or run tests for the changes. From 2e42827a14fc33e2b9bee5d28bb05a4deb7f40e7 Mon Sep 17 00:00:00 2001 From: Saket Harsh Date: Mon, 27 Jan 2025 14:36:28 +0530 Subject: [PATCH 10/10] Update pull_request_template.md Signed-off-by: Saket Harsh --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3bcb883..d64cf12 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,7 +3,7 @@ Include a descripton of what this change does. Type - Bug/New Feature/Improvements -[ ] Attached PR link on the Asana task +- [ ] Attached PR link on the Asana task Design Doc Link -