Tag imports for interop

Fix [#2](#2).

Author: NoahTheDuke

src/noahtheduke/spat/ns_parser.clj

@@ -17,23 +17,25 @@
     form))
 
 (defn parse-imports [args]
-  (reduce
-    (fn [acc cur]
-      (cond
-        (symbol? cur)
-        (assoc acc cur cur)
-        (seq? cur)
-        (let [prefix (first cur)
-              aliases (rest cur)]
-          (reduce
-            (fn [acc alias_]
-              (let [full-name (symbol (str prefix "." alias_))]
-                (-> acc
-                    (assoc alias_ full-name)
-                    (assoc full-name full-name))))
-            acc aliases))
-        :else acc))
-    {} args))
+  (persistent!
+    (reduce
+      (fn [acc cur]
+        (cond
+          (symbol? cur)
+          (assoc! acc cur cur)
+          (seq? cur)
+          (let [prefix (first cur)
+                aliases (rest cur)]
+            (reduce
+              (fn [acc alias_]
+                (let [full-name (symbol (str prefix "." alias_))]
+                  (-> acc
+                      (assoc! alias_ full-name)
+                      (assoc! full-name full-name))))
+              acc aliases))
+          :else acc))
+      (transient {})
+      args)))
 
 (defmethod derive-aliases 'import
   [[_ & args]]

src/noahtheduke/spat/parser.clj

@@ -10,6 +10,13 @@
 
 (set! *warn-on-reflection* true)
 
+(defn attach-import-meta [ns-state obj]
+  (if-let [ns_ (and (symbol? obj) (some-> obj namespace symbol))]
+    (if-let [fqns (get-in @ns-state [:imports ns_])]
+      (vary-meta obj assoc :spat/import-ns fqns)
+      obj)
+    obj))
+
 (defn make-edamame-opts [ns-state]
   {:all true
    :row-key :line
@@ -35,7 +42,8 @@
                   ;; Gotta apply location data here as using `:postprocess` skips automatic
                   ;; location data
                   (if (e/iobj? obj)
-                    (vary-meta obj merge loc)
+                    (->> (vary-meta obj merge loc)
+                         (attach-import-meta ns-state))
                     obj))
    :uneval (fn [{:keys [uneval next]}]
              (cond

src/noahtheduke/splint/rules/lint/fn_wrapper.clj

@@ -4,10 +4,16 @@
 
 (ns ^:no-doc noahtheduke.splint.rules.lint.fn-wrapper
   (:require
-    [noahtheduke.splint.rules :refer [defrule]]))
+    [noahtheduke.splint.rules :refer [defrule]]
+    [noahtheduke.splint.diagnostic :refer [->diagnostic]]
+    [noahtheduke.splint.rules.helpers :refer [default-import?]]))
 
 (set! *warn-on-reflection* true)
 
+(defn interop? [sexp]
+  (or (some->> sexp namespace symbol default-import?)
+      (some->> sexp meta :spat/import-ns)))
+
 (defrule lint/fn-wrapper
   "Avoid wrapping functions in pass-through anonymous function defitions.
 
@@ -27,5 +33,7 @@
   "
   {:patterns ['(%fn?? [?arg] (?fun ?arg))
               '(%fn?? ([?arg] (?fun ?arg)))]
-   :message "No need to wrap function. Clojure supports first-class functions."
-   :replace '?fun})
+   :on-match (fn [ctx rule form {:syms [?fun ?args]}]
+               (when-not (interop? ?fun)
+                 (->diagnostic rule form {:replace-form ?fun
+                                          :message "No need to wrap function. Clojure supports first-class functions."})))})

test/noahtheduke/splint/rules/lint/fn_wrapper_test.clj

@@ -5,9 +5,13 @@
 (ns noahtheduke.splint.rules.lint.fn-wrapper-test
   (:require
     [expectations.clojure.test :refer [defexpect expect]]
-    [noahtheduke.splint-test :refer [check-alt]]))
+    [noahtheduke.splint-test :refer [check-alt check-all]]))
 
 (defexpect fn-wrapper-test
   (expect 'f (check-alt "(fn* [arg] (f arg))"))
   (expect 'f (check-alt "(fn [arg] (f arg))"))
   (expect 'f (check-alt "#(f %)")))
+
+(defexpect interop-static-test
+  (expect nil (check-alt "#(Integer/parseInt %)"))
+  (expect nil (check-all "(do (import (java.util.regex Pattern)) #(Pattern/compile %))")))