Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notion File uploads not working anymore - changed signed url approach #576

Closed
mfts opened this issue Nov 4, 2024 · 3 comments
Closed

Notion File uploads not working anymore - changed signed url approach #576

mfts opened this issue Nov 4, 2024 · 3 comments

Comments

@mfts
Copy link
Contributor

mfts commented Nov 4, 2024

Description

I read a bunch about how signed urls are managed in Notion, but it seems that they changed their approach over the years. Especially recently all uploaded files are stored on their s3 storage and on download it creates a signed url.

However, the current approach with react-notion-x isn't extracting the signed url.
Perhaps I'm not sure how to enable it or find a solution.

Notion Test Page ID

Here's an example page id: 12fd3f870f0080499b22f16d84dadd89

Error message

Just getting a standard not authorized error from s3 when I try to download the file without the signed params:
https://prod-files-secure.s3.us-west-2.amazonaws.com/fc2e943e-e403-4068-b5f1-0096c54c3063/ff0da6e6-b954-4dfc-a684-8a00c10cc582/papermark-example-document.zip

@rimonhanna
Copy link
Contributor

fixed in #455

@transitive-bullshit
Copy link
Member

Merged #455 and released in https://github.com/NotionX/react-notion-x/releases/tag/react-notion-x%407.2.4

Let me know if you're still seeing issues && thanks 🙏

@wustep
Copy link
Contributor

wustep commented Nov 19, 2024

hmm I think this is leading to some side effects because of how we're appending &spaceId without checking if there's ? first, and then this throws off a few things

#588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants