Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OHIF plugin for Orhtanc fails to build for Windows #3748

Open
IsmailAlamKhan opened this issue Oct 27, 2023 · 2 comments
Open

[Bug] OHIF plugin for Orhtanc fails to build for Windows #3748

IsmailAlamKhan opened this issue Oct 27, 2023 · 2 comments

Comments

@IsmailAlamKhan
Copy link

Describe the Bug

Describe Your Question

  1. I am trying to customize OHIF and compiling the OHIF plugin for Orthanc. Its generating a .so file which is for Linux but unable to build a .dll file for Windows.
  2. I am using OHIF Viewer 3.6.0

I am following this to build the OHIF plugin OHIF plugin — Orthanc Book documentation

Steps to Reproduce

  1. Customize OHIF.
  2. Build the Viewers-3.6.0 archive required by the Orthanc plugin.
  3. Try to compile for Windows.

The current behavior

Fails to compile when I try to build on Windows but passes when I build on Linux.

The expected behavior

Should compile on Windows and output a dll file.

OS

Windows 11

Node version

latest NodeJS

Browser

latest firefox

@IsmailAlamKhan IsmailAlamKhan added the Awaiting Reproduction Can we reproduce the reported bug? label Oct 27, 2023
@imlliu2005
Copy link

Windows 下编译方法
1.下载orthancohif 源码(https://orthanc.uclouvain.be/downloads/sources/orthanc-ohif/OrthancOHIF-1.2.tar.gz)
2.下载viewers(https://github.com/OHIF/Viewers)源码,build出dist,为编译orthancohif 最准备
3.build 参考(https://orthanc.uclouvain.be/book/plugins/ohif.html)
4.将build好的viewer 拷贝到OrthancOHIF-1.2\OHIF\dist目录下(如果是在linux平台步骤2、3执行脚本[../Resources/CreateOHIFDist.sh]就可以完成)这个脚本的工作就干了两件事情 1)下载viewers源码进 2)编译源码将结果拷贝到OrthancOHIF-1.2\OHIF\dist目录。这部分编译在docker进行,windows 就直接build了手动拷贝
5.cmake 配置OrthancOHIF (cmake ../ -G "Visual Studio 16 2019" -A x64 -DMSVC_MULTIPLE_PROCESSES=ON -DSTATIC_BUILD=ON -DOPENSSL_NO_CAPIENG=ON -DALLOW_DOWNLOADS=ON)
或者简单点:cmake ../ -G "Visual Studio 16 2019" -A x64 -DSTATIC_BUILD=ON -DALLOW_DOWNLOADS=ON
6.生成vs工程后打开项目进行build 即可

@sedghi
Copy link
Member

sedghi commented May 4, 2024

is this still an issue in master

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants