[Bug] Error: Failed to normalize the multiframe dataset, the data is not multi-frame

[victormylle-dm]

Describe the Bug

I have an issue with OHIF 3.8.5, when I want to segment a patient, the brush becomes very laggy and no segmentation is done. This doesn't happen with all patient, most of them work fine. I tried updating OHIF to version 3.9.0 and 3.9.1, which resolved the laggy brush issue. Now I am able to create segmentation for all patients but when trying to save the segmentation it gives an error:

Route /segmentation Error Boundary
Error: Failed to normalize the multiframe dataset, the data is not multi-frame. — null "Route /segmentation"

Now, i am not able to segment any patient anymore, all of them fail when trying to save.

Steps to Reproduce

1. Segment patient
2. Save patient

The current behavior

In Bug description

The expected behavior

The brush should not be laggy and segmentations should be saved properly.

OS

macOS 15.1

Node version

18.16.1

Browser

Safari 18.1, Firefox 132.0.2

[sedghi]

This is not enough detail for bug report. Can you give us videos, images, or data?

[victormylle-dm]

I won't be able to provide you with the data but I have screen recordings. The first one is a screen recording of the behavior in version 3.8.5 and the second one is the behavior in version 3.9.1. You can see that the segmentation does not work in 3.8.5 while it works in 3.9.1. But then when I want to save the segmentation, an error occurs. The error occurs for every patient (not only the ones that did not work in 3.8.5)

OHIF.3.8.5.mov

OHIF.3.9.1.mp4

[victormylle-dm]

So I went deep on this issue and found where it goes wrong.

Viewers/extensions/cornerstone/src/panels/PanelSegmentation.tsx

Lines 79 to 81 in 76fb2f5

	storeSegmentation: async segmentationId => {
	commandsManager.run('storeSegmentation', { segmentationId });
	},

Here a call to the commandsManager is done for 'storeSegmentation' without a given context.

Viewers/platform/core/src/classes/CommandsManager.ts

Line 202 in 76fb2f5

const { commandName, commandOptions, context } = command;

Next, on this line the context is still empty. In the runCommand function, the command definition is tried to be fetched.

Viewers/platform/core/src/classes/CommandsManager.ts

Lines 119 to 127 in 76fb2f5

	if (Array.isArray(contextName)) {
	contexts.push(...contextName.map(name => this.getContext(name)).filter(it => !!it));
	} else if (contextName) {
	const context = this.getContext(contextName);
	if (context) {
	contexts.push(context);
	}
	}

The command is searched over all contexts but the same command name is used in the CORNERSTONE context and SEGMENTATION context. A for loop is done over these contexts so the storeSegmentation of the SEGMENTATION context will be run. This function, however, requires a datasource as argument but this is never given. The CORNERSTONE storeSegmentation will call the SEGMENATION context command and gives it the datasource argument.

I think we want the CORNERSTONE storeSegmentation to be called first.

I did a dirty fix by replacing:

Viewers/extensions/cornerstone/src/panels/PanelSegmentation.tsx

Lines 79 to 81 in 76fb2f5

	storeSegmentation: async segmentationId => {
	commandsManager.run('storeSegmentation', { segmentationId });
	},

with

storeSegmentation: async segmentationId => { commandsManager.run({commandName: 'storeSegmentation', context: 'CORNERSTONE'}, { segmentationId }, ); },
This saves the segmentation now but the segmentation is saved in reverse!

[victormylle-dm]

When saving the segmentation, the segmentation is saved in reverse! The dirty fix does not work completely!

[sedghi]

Without data to reproduce the issue, I can't really help. I hope you understand that the problem is related to the data.