Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SR report is not loading in local data source. #4630

Closed
ashik-trenser opened this issue Dec 30, 2024 · 1 comment · Fixed by #4693
Closed

[Bug] SR report is not loading in local data source. #4630

ashik-trenser opened this issue Dec 30, 2024 · 1 comment · Fixed by #4693
Assignees
Labels
Bugs Bug reported, reproducible, and verified.

Comments

@ashik-trenser
Copy link
Contributor

Describe the Bug

When trying to load an SR in a viewport using local data source, the viewport is blacked out, and a notification indicating something went wrong is shown.
Image

Steps to Reproduce

  1. Open a file with SR in the local data source.
  2. Try loading the SR to the viewport.

The current behavior

The viewport is blacked out and a notification indicating something went wrong is shown.

The expected behavior

The SR should be loaded successfully in the viewport.

OS

Windows 11

Node version

v18.19.0

Browser

Chrome 131.0.6778.205

@ashik-trenser ashik-trenser added the Awaiting Reproduction Can we reproduce the reported bug? label Dec 30, 2024
@sedghi sedghi self-assigned this Jan 6, 2025
@ChaoStraxcorp
Copy link
Contributor

ChaoStraxcorp commented Jan 14, 2025

I also encountered this issue.
Screenshot 2025-01-14 at 11 12 59 pm

This issue occurs in both the master branch and version 3.9.2 but does not appear in version 3.9.1.

I think this bug was introduced in [PR #4554]](#4554 ). In [1], the change is made to handle multi-frame images. As a result, instead of using the imageId as the key of the data mapping, the latest update uses frameImageId (imageId&Frame=##). It leads to the metadataProvider.getUIDsFromImageID being unable to get the image UID by the image ID without the frame number.

I have created a PR for the fix.

@sedghi sedghi added the Bugs Bug reported, reproducible, and verified. label Jan 15, 2025 — with Linear
@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Jan 15, 2025
@sedghi sedghi mentioned this issue Jan 16, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bug reported, reproducible, and verified.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants