Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequelstring (SA: RET11) - Compliance Check #3012

Open
Jagannath-wits opened this issue Dec 31, 2024 · 4 comments
Open

Sequelstring (SA: RET11) - Compliance Check #3012

Jagannath-wits opened this issue Dec 31, 2024 · 4 comments

Comments

@Jagannath-wits
Copy link
Collaborator

Jagannath-wits commented Dec 31, 2024

Flow 1

Search inc. and on Search inc. are not provided in the flow

On Search

  • bpp/providers/locations/circle/radius value should not exceed 500 kms
  • Serviceability not captured properly; category missing
  • Serviceability for F&B can’t be PAN india.
  • collect_payment is not required in bpp/descriptor/tags unless you want to collect payment
  • no items mapped with custom menu CM11 and CM12 in providers/items
  • parent_category_id should be present while type is custom_menu
  • serviceability construct /bpp/providers[0]/tags[0] (refer to API contract)
  • "@ondc/org/fssai_license_no should not have less than 14 characters

FLow 2

Select

  • location_id missing from message/order/items[0]

On Init

  • /message/order/payment must have required property '@ondc/org/buyer_app_finder_fee_type' and '@ondc/org/buyer_app_finder_fee_amount'
  • 'cancellation_terms' in /message/order should not be provided as those are not enabled yet
  • tags/code tax number should be a valid one (i.e alphanumeric with 15 characters)
  • Missing provider_tax_number for on init
  • "@ondc/org/settlement_details/upi_address" is blank

On Confirm

  • why is np_type missing in message/order/tags/bpp_terms for ON_CONFIRM?

###on status pending is missing

On status

  • message/order/payment must have required property '@ondc/org/buyer_app_finder_fee_type' and '@ondc/org/buyer_app_finder_fee_amount'
  • tags/tracking/url is not accessible

Flow 3

Missing calls from the flow. Please provide for validation

Flow 4

On Cancel

  • message/order must have required property 'billing'
  • cancelled_by entity should be same as context/bap_id
  • CancellationID 006 is not allowed for SNP
  • Tags are missing (fulfillment type delivery)
  • initiated by is also missing
  • Pre Cancel is mandatory for on_cancel

Flow 5

- Empty payload for on_cancel_rto and on_status_rto

please refer to Manual validations checklist

Flow 6

Missing calls from the flow. Please provide for validation

@Nirdosh3312

@simranOndc
Copy link

@Nirdosh3312 Please update.

@Nirdosh3312
Copy link
Contributor

Hi @Jagannath-wits / @sandeepshahi , We have updated the logs for the issues mentioned here, in PR #3261. Please let me know if anything else is required. Looking forward to your response.

Regards

@FarheenNazz
Copy link

FarheenNazz commented Feb 17, 2025

Sequalstring SA RET11

Flow1-

On_search -

  • bpp/fulfillments- F2,type must be equal to one of the allowed values (Delivery,Self-Pickup) .Given-Buyer-Delivery which is incorrect.
  • items.quantity.available count must be either 99 or 0 only”(e.g. item_id- id_1cctu3_9_0)
  • bpp/providers.descriptor - The provided information is not genuine. The Name, short description, and long description are the same, and the images do not match the provided details. Same error for item_id- id_ancc5_0_0.
  • Serviceability for F&B can’t be PAN india.

search_inc_refresh -

  • Timestamp for /on_search api cannot be greater than or equal to /inc_search api.

On_search_inc -

  • Only incremental changes should be provided in this call. The current call contains the same payload as the full On_search, which is incorrect.

Flow 2 -

On_init-

  • items.quantity.max and items.quantity.available should not be included in this call.
  • cancellation_terms' in /message/order should not be provided as those are not enabled yet.

On_status_picked-

  • Documents.url is not accessible.

Flow 6 -

  • update settlement for liquidation Api is missing.
    @Nirdosh3312

@simranOndc
Copy link

@Nirdosh3312 share the PR link for verification, lets close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants