Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better return values for concept cluster/pipeline deletion method #214

Open
fmatthies opened this issue May 14, 2024 · 1 comment
Open
Assignees
Labels
concepts/documents Related to concepts or documents logic enhancement New feature or request

Comments

@fmatthies
Copy link
Contributor

The following two deletion methods both return a ResponseEntity<void>:

  • ConceptPipelineApiDelegateImpl.deleteConceptPipelineById
  • ConceptClusterApiDelegateImpl.deleteConceptClustersForPipelineId

Maybe it's more feasible to change this to a ResponseEntity<PipelineResponse>; this would need a change in top-api as well, as those methods are overrides.

@fmatthies fmatthies added enhancement New feature or request concepts/documents Related to concepts or documents logic labels May 14, 2024
@fmatthies fmatthies self-assigned this May 14, 2024
@fmatthies
Copy link
Contributor Author

For deleteConceptPipelineById one could also think about an option to only partially delete (or better pick up where failed previously because there are already steps present)
The second option could/should be checked in top-frontend startPipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concepts/documents Related to concepts or documents logic enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant