Skip to content

Commit 22461a8

Browse files
committed
tidy after export_data_access_groups
ref #186 and reorder parmaeters more #204
1 parent c542841 commit 22461a8

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

NEWS

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@ Minor New Features:
1212
should be returned with the `character` data type. The default is to allow `readr::read_csv()` to guess the data type. (#194)
1313
* `redcap_read_oneshot()` allows use to specify how many rows should be considered when `readr::read_csv()` guesses the data type. (#194)
1414
* `redcap_read()`, `redcap_read_oneshot()`, and `redcap_read_eav()` always return Linux-style line endings (ie `\n`) instead of Windows style line endings (ie, `\r\n`) on all OSes. (#198)
15-
* Link to new secure Zenodo DOI resolver (katrinleinweber #191)
1615
* `read_metadata()` always returns `character` vectors for all variables. With readr 1.2.0, some column were returned differently than before. (#193)
17-
* 'raw_orLabel_headers' now supprted (Thanks Hatem Hosny - hatemhosny, #183 & #203)
16+
* 'raw_or_label_headers' now supported (Thanks Hatem Hosny - hatemhosny, #183 & #203)
17+
* 'export_checkbox_labels' now supported (#186)
18+
* Link to new secure Zenodo DOI resolver (katrinleinweber #191)
19+
* parameters in `redcap_read()` and `redcap_read_oneshot()` are more consistent with the order in raw REDCap API. (#204)
1820

1921
Modified Internals:
2022
* When converting REDCap's CSV to R's data.frame, `readr::read_csv()` is used instead of `utils::read.csv()` (Issue #127).

R/redcap-read-oneshot.R

+3-2
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ redcap_read_oneshot <- function(
8282
events = NULL, events_collapsed = "",
8383
raw_or_label = "raw",
8484
raw_or_label_headers = "raw",
85-
export_checkbox_label = FALSE, # exportCheckboxLabel
85+
export_checkbox_label = FALSE,
8686
# returnFormat
8787
export_survey_fields = FALSE,
8888
export_data_access_groups = FALSE,
@@ -243,8 +243,9 @@ redcap_read_oneshot <- function(
243243
outcome_message = outcome_message,
244244
records_collapsed = records_collapsed,
245245
fields_collapsed = fields_collapsed,
246-
filter_logic = filter_logic,
246+
# forms
247247
events_collapsed = events_collapsed,
248+
filter_logic = filter_logic,
248249
elapsed_seconds = elapsed_seconds,
249250
raw_text = raw_text
250251
) )

R/redcap-read.R

+13-7
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ redcap_read <- function(
8383
events = NULL, events_collapsed = "",
8484
raw_or_label = "raw",
8585
raw_or_label_headers = "raw",
86-
export_checkbox_label = FALSE, # exportCheckboxLabel
86+
export_checkbox_label = FALSE,
8787
# returnFormat
8888
export_survey_fields = FALSE,
8989
export_data_access_groups = FALSE,
@@ -141,8 +141,9 @@ redcap_read <- function(
141141
token = token,
142142
records_collapsed = records_collapsed,
143143
fields_collapsed = metadata$data$field_name[1],
144-
filter_logic = filter_logic,
144+
# forms
145145
events_collapsed = events_collapsed,
146+
filter_logic = filter_logic,
146147
guess_type = guess_type,
147148
verbose = verbose,
148149
config_options = config_options
@@ -156,8 +157,9 @@ redcap_read <- function(
156157
data = data.frame(),
157158
records_collapsed = "failed in initial batch call",
158159
fields_collapsed = "failed in initial batch call",
159-
filter_logic = "failed in initial batch call",
160+
# forms
160161
events_collapsed = "failed in initial batch call",
162+
filter_logic = "failed in initial batch call",
161163
elapsed_seconds = elapsed_seconds,
162164
status_code = initial_call$status_code,
163165
outcome_messages = outcome_messages,
@@ -195,13 +197,16 @@ redcap_read <- function(
195197
token = token,
196198
records = selected_ids,
197199
fields_collapsed = fields_collapsed,
198-
filter_logic = filter_logic,
199200
events_collapsed = events_collapsed,
200-
export_survey_fields = export_survey_fields,
201-
export_data_access_groups = export_data_access_groups,
201+
# forms
202202
raw_or_label = raw_or_label,
203203
raw_or_label_headers = raw_or_label_headers,
204204
export_checkbox_label = export_checkbox_label,
205+
# return_format
206+
export_survey_fields = export_survey_fields,
207+
export_data_access_groups = export_data_access_groups,
208+
filter_logic = filter_logic,
209+
205210
guess_type = guess_type,
206211
verbose = verbose,
207212
config_options = config_options
@@ -238,8 +243,9 @@ redcap_read <- function(
238243
outcome_messages = outcome_message_combined,
239244
records_collapsed = records_collapsed,
240245
fields_collapsed = fields_collapsed,
241-
filter_logic = filter_logic,
246+
# forms
242247
events_collapsed = events_collapsed,
248+
filter_logic = filter_logic,
243249
elapsed_seconds = elapsed_seconds
244250
) )
245251
}

0 commit comments

Comments
 (0)