Skip to content

Commit 9e8a7d3

Browse files
committed
change logical 'or' to 'and'
ref #317
1 parent 346e593 commit 9e8a7d3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

R/redcap-read.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ redcap_read <- function(
340340
}
341341

342342
lst_batch[[i]] <- read_result$data
343-
success_combined <- success_combined | read_result$success
343+
success_combined <- success_combined & read_result$success
344344

345345
rm(read_result) #Admittedly overkill defensiveness.
346346
}

R/redcap-write.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ redcap_write <- function(
172172
}
173173

174174
affected_ids <- c(affected_ids, write_result$affected_ids)
175-
success_combined <- success_combined | write_result$success
175+
success_combined <- success_combined & write_result$success
176176

177177
rm(write_result) #Admittedly overkill defensiveness.
178178
}

tests/testthat/test-write-error.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ test_that("Single Batch: writing with read-only privileges --contiue on error",
7676
result <- REDCapR::redcap_write(ds=mtcars, redcap_uri=credential$redcap_uri, token=credential$token, continue_on_error=TRUE)
7777
))
7878

79-
expect_true( result$success)
79+
expect_false(result$success)
8080
expect_equal(result$status_code, expected="403")
8181
expect_equal(result$outcome_message, expected_message)
8282
expect_equal( result$records_affected_count, 0L)
@@ -97,7 +97,7 @@ test_that("Many Batches: writing with read-only privileges --contiue on error",
9797
result <- REDCapR::redcap_write(ds=mtcars, redcap_uri=credential$redcap_uri, token=credential$token, continue_on_error=TRUE, batch_size=10)
9898
))))
9999

100-
expect_true( result$success)
100+
expect_false(result$success)
101101
expect_equal(result$status_code, expected="403; 403; 403; 403")
102102
expect_match(result$outcome_message, expected_message)
103103
expect_equal( result$records_affected_count, 0L)

0 commit comments

Comments
 (0)