Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly specify httr::POST()'s value for encode #436

Closed
wibeasley opened this issue Oct 1, 2022 · 2 comments
Closed

explicitly specify httr::POST()'s value for encode #436

wibeasley opened this issue Oct 1, 2022 · 2 comments
Assignees

Comments

@wibeasley
Copy link
Member

wibeasley commented Oct 1, 2022

related #429 & to @brandonpotvin's implicit suggestion, REDCapR should be tighter with httr::POST()'s encode parameter. Right now, it uses httr's default of "multipart". Looking at some things closely (like the API playground & httr documentation), it looks like most (but not all) should be "form".

This hasn't made a difference with any scenarios that I'm aware of. But I'd like to standardize now, since some institutions are starting unconventional approaches. I feel like following the API playground keeps more people centered.

@wibeasley wibeasley self-assigned this Oct 1, 2022
@wibeasley
Copy link
Member Author

@brandonpotvin, this shouldn't be noticeable to you. But if you notice something weird/breaking in future cases, let's revisit this issue first.

@brandonpotvin
Copy link

@wibeasley, everything seems to be working as expected. I will let you know if I find something. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants