-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guzzle 6 support #1562
Comments
|
From my previous reply: Is Guzzle 7 a hard requirement for this to work or could we loosen up the requirement to ^6.3.1|^7.0? Installing in a clean Laravel 7.0 install currently doesn't allow 1.14 to be installed, which I'm afraid will cause a lot of confusing among the Laravel Excel users who want to upgrade to use the backwards compatible fix for the empty enclosures which was fixed in 1.14. |
Looking at the PR itself I don't see anything that would be Guzzle 7 only. |
Guzzle 7 supports PSR-18, but Guzzle 6 does not. This is a problem for us since we rely on PSR-18 in order to be flexible and allow users to change the HTTP client with something else (via I don't see an obvious way to still rely on PSR-18 while supporting both Guzzle 6 and 7 out of the box. I'm thinking the easiest for now is for PhpSpreadsheet to require I'd merge a PR for that if it also includes documentation and an exception that explain the situation if edit: that means if you don't need |
Which one would that be? In the release notes nothing stands out to me at https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/1.14.0? |
Given that Guzzle 7 is less than a week old, I don't think it's reasonable to expect people to be able to finish migrating for at least another half year. |
Ah I'm very sorry, I made a total mistake. Just ignore :-) |
TL;DR:
I've just upgraded PhpSpreadsheet on my project and see a new dependency on Guzzle and I think this is not the best option. Not because Guzzle is bad (it's not), but because you're forcing users to require Guzzle where it's not particularly needed. Guzzle implements PSR-18 and therefore PhpSpreadsheet should depend only on the The HTTP part is not a mandatory feature at all, therefore I'd expect it to allow me to provide any HTTP client among the many clients that implement PSR-18. I would instead put Guzzle (or any other HTTP client implementing PSR-18) into the I would be glad to help refactor the current HTTP feature if you like 🙂 |
Sounds good @Pierstoval ! I think @PowerKiKi already mentioned he would accept a PR to change it, so I would say go ahead! :) |
Here you are @patrickbrouwers: #1568 😉 |
This is:
PHPSpreadsheet 1.14 only supports Guzzle 7. As it is only released a few days ago most of us are still on Guzzle 6. Please lower the requirements for Guzzle so we can take advantage of the bugfixes.
The text was updated successfully, but these errors were encountered: