Skip to content

Commit 4696ef2

Browse files
committed
fix early stop test bug
1 parent 2a6b14c commit 4696ef2

3 files changed

+2
-14
lines changed

test/core/test_async_batch_advisor.py

-12
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,3 @@ def test_async_batch_advisor_initialization(configspace_tiny, history_single_obs
3434
advisor.update_observation(observation)
3535
assert len(advisor.history) == 1
3636

37-
38-
def test_async_batch_advisor_early_stop(configspace_tiny):
39-
config_space = configspace_tiny
40-
advisor = AsyncBatchAdvisor(config_space, early_stop=True, early_stop_kwargs={'min_iter': 3, 'min_improvement_percentage': 100})
41-
42-
for i in range(3):
43-
suggestion = advisor.get_suggestion()
44-
observation = Observation(suggestion, [10-i], trial_state=SUCCESS, elapsed_time=2.0, extra_info={})
45-
advisor.update_observation(observation)
46-
47-
with pytest.raises(EarlyStopException):
48-
advisor.get_suggestion()

test/core/test_mf_batch_advisor.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test_mf_batch_advisor(configspace_tiny, history_single_obs):
4848

4949
def test_mf_advisor_early_stop(configspace_tiny):
5050
config_space = configspace_tiny
51-
advisor = MFBatchAdvisor(config_space, early_stop=True, early_stop_kwargs={'min_iter': 3, 'min_improvement_percentage': 100})
51+
advisor = MFBatchAdvisor(config_space, early_stop=True, early_stop_kwargs={'min_iter': 3, 'min_improvement_percentage': 1e8})
5252

5353
for i in range(3):
5454
suggestion = advisor.get_suggestions(1)[0]

test/core/test_sync_batch_advisor.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_sync_batch_advisora(configspace_tiny, history_single_obs):
5555

5656
def test_sync_batch_advisor_early_stop(configspace_tiny):
5757
config_space = configspace_tiny
58-
advisor = SyncBatchAdvisor(config_space, early_stop=True, early_stop_kwargs={'min_iter': 3, 'min_improvement_percentage': 100})
58+
advisor = SyncBatchAdvisor(config_space, early_stop=True, early_stop_kwargs={'min_iter': 3, 'min_improvement_percentage': 1e8})
5959

6060
for i in range(3):
6161
suggestion = advisor.get_suggestion()

0 commit comments

Comments
 (0)