Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute #70

Closed
bvssvni opened this issue May 13, 2014 · 157 comments
Closed

How to contribute #70

bvssvni opened this issue May 13, 2014 · 157 comments

Comments

@bvssvni
Copy link
Member

bvssvni commented May 13, 2014

The guidelines are moved here

@thehydroimpulse
Copy link

👍 Gonna start getting into Rust game dev. I've been working on a ton of networking in Rust recently.(Designing a gossip protocol)

Not sure if multiplayer stuff is in the scope of piston or not.

(I also missed the last ludum dare, so I wanna catch the next one and use Rust for it)

@bvssvni
Copy link
Member Author

bvssvni commented May 15, 2014

Cool! I is nice to have people looking at Piston from that perspective, because this helps improve the design. Feel free to post issues about ideas around multiplayer, gossip etc.

@bvssvni
Copy link
Member Author

bvssvni commented May 31, 2014

We will keep this issue updated even if it is closed.

@reem
Copy link
Member

reem commented Jun 10, 2014

Is there a reason we don't have this information in a CONTRIBUTING.md so github points everyone to it when they try and file an issue/make a PR?

@bvssvni
Copy link
Member Author

bvssvni commented Jun 10, 2014

@reem no, I didn't knew about that feature. Do you want to add it?

@reem
Copy link
Member

reem commented Jun 10, 2014

Just made a PR adding it.

@UberLambda
Copy link

Since I've been learning Rust for just two weeks (but I have coded in C++ for ~2 years), and so I'm still a rookie, I'd have some questions:

  1. How easy are the "easy" tasks mentioned in CONTRIBUTING.md?
  2. Is there any code I can start fixing/adding now, just to get used to the engine's structure? Or should I just stick to reverse engineering the engine for now?
  3. Would a basic (component-based?) scene graph fit in the scope of this engine? Is this project aimed to become a game engine or a high-level multimedia API?

@bvssvni
Copy link
Member Author

bvssvni commented Jul 1, 2014

@UberLambda The "Easy" labels are used about stuff that require less thinking. It doesn't always apply to the amount of code.

Feel free to look around. Also nice if you open issues about gaps in the documentation.

We have no "roof" yet, because we use a very flat maintainer structure. If you got ideas, open up an issue. A scene graph would be very interesting. I picture the Piston project as a set of libraries designed to be used independently but also working nicely together. It is an open question whether the "game engine" lives in the individual parts or the sum as whole.

@UberLambda
Copy link

@bvssvni I'll try to find something in the easy tasks for now, then 👍

@mkcp
Copy link
Contributor

mkcp commented Sep 2, 2014

Hey all, looking to contribute. Got a lot of time now and I'd like to do some meaningful work in rust.

@bvssvni
Copy link
Member Author

bvssvni commented Sep 2, 2014

@mkcp Welcome to the team!

@maxsnew
Copy link
Contributor

maxsnew commented Sep 2, 2014

Looking to contribute as well. Want to get my feet wet with some larger-scale rust.

@bvssvni
Copy link
Member Author

bvssvni commented Sep 2, 2014

@maxsnew Welcome to the team!

@DarrenTsung
Copy link
Contributor

Hi, I'm was trying to get started with Piston yesterday with the getting-started tutorial (https://github.com/PistonDevelopers/Piston-Tutorials/tree/master/getting-started), but encountered a few bugs due to recent changes to EventIterator. I'd like to contribute and hopefully update the tutorial to work with a bit of help!

@bvssvni
Copy link
Member Author

bvssvni commented Nov 7, 2014

@DarrenTsung Welcome to the team! I sent you an invitation.

@ZoeyR
Copy link

ZoeyR commented Nov 19, 2014

I'm looking to contribute as well. I enjoy bug fixing and am looking to contribute to a large project.

@bvssvni
Copy link
Member Author

bvssvni commented Nov 19, 2014

@dgriffen Welcome to the team! I sent you an invitation.

@gchp
Copy link
Member

gchp commented Nov 19, 2014

Is there a code of conduct for contributors? I was recently added, and had some questions on etiquette. These kind of things can vary from project to project, so just wanted to clarify some things for the Piston group.

Some questions:

  • Is it ever acceptable to push directly to a repo?
  • When is it ok to accept a PR? For instance, should they be signed off by the individual repo's maintainer?
  • Is there a checklist for validating PRs? ie tests passing, commit message format etc.

Looking forward to working with you all!

@bvssvni
Copy link
Member Author

bvssvni commented Nov 19, 2014

@gchp I sometimes do analysis of "best practice" and then label with the "Information" tag. For example, self merging is encouraged under certain conditions #674 because it saves time. When problems appear we usually try to solve them isolated without adding another "rule" that everybody must follow, but we use the same labels everywhere so people recognize them.

@mlschneid
Copy link

I'd like to contribute to your projects! I am hoping Rust really takes off and I think this is a good place to start.

@bvssvni
Copy link
Member Author

bvssvni commented Dec 19, 2014

@mlschneid Welcome to the team! I sent you an invitation.

@evenlis
Copy link

evenlis commented Dec 24, 2014

Hi, I'd like to contribute to your project. I've really enjoyed learning Rust so far, and would very much like to contribute to projects I expect to popularise Rust (such as this one).

@bvssvni
Copy link
Member Author

bvssvni commented Dec 25, 2014

@evenlis Welcome to the team! I sent you an invitation.

@dcampbell24
Copy link
Member

I want to contribute to Piston.

@bvssvni
Copy link
Member Author

bvssvni commented Jan 14, 2015

@davekong Welcome to the team! I sent you an invitation.

@bvssvni
Copy link
Member Author

bvssvni commented Apr 28, 2018

@collin5 Welcome to the team! I sent you an invitation.

@leftiness
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented May 30, 2018

@leftiness Welcome to the team! I sent you an invitation.

@PinkFloyded
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented May 31, 2018

@PinkFloyded Welcome to the team! I sent you an invitation.

@dineshadepu
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Jul 12, 2018

@dineshadepu Welcome to the team! I sent you an invitation.

@r-o-b-o-t-o
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Sep 30, 2018

@robot0 Welcome to the team! I sent you an invitation.

@quietlychris
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Oct 4, 2018

@quietlychris Welcome to the team! I sent you an invitation.

@fintelia
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Oct 15, 2018

@fintelia Welcome to the team! I sent you an invitation.

@ateraz13
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Oct 29, 2018

@self-unaware Welcome to the team! I sent you an invitation.

@arthmis
Copy link

arthmis commented Nov 13, 2018

I want to contribute to piston

@bvssvni
Copy link
Member Author

bvssvni commented Nov 13, 2018

@LazyPassion Welcome to the team! I sent you an invitation.

@KenSuenobu
Copy link

Would like to contribute. I have several years of development with Atari GEM (helped with several GEM projects) and some experience with Qt/KDE. Would like to help simplify the library, and make things more efficient!

@bvssvni
Copy link
Member Author

bvssvni commented Dec 7, 2018

@KenSuenobu Welcome to the team! I sent you an invitation.

@Kagami
Copy link
Member

Kagami commented Dec 31, 2018

I think I wasn't officially invited, so commenting here just in case. I'm contributing to 3 repos:
https://github.com/PistonDevelopers/gfx_text
https://github.com/PistonDevelopers/resize
https://github.com/PistonDevelopers/y4m
and would like to keep access to them. Thanks.

@retep998
Copy link
Member

Since I haven't had any comments on this issue yet but have been in the organization for a while and have contributed, I'd like to retain my status.

@bvssvni
Copy link
Member Author

bvssvni commented Dec 31, 2018

@Kagami @retep998 no problem!

@shanehandley
Copy link

shanehandley commented Sep 26, 2019

I want to contribute to Piston

Specifically: I'd like to help out with Conrod maintenance and attending to issues.

@bvssvni
Copy link
Member Author

bvssvni commented Sep 26, 2019

@shanehandley Welcome to the team! I sent you an invitation.

@bvssvni
Copy link
Member Author

bvssvni commented Oct 9, 2019

@gratispress Can you open up a new issue to discuss this? This thread is for people who want to contribute to Piston and need write access.

@bodagovsky
Copy link

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Jan 4, 2020

@mario-s
Copy link

mario-s commented Jan 11, 2021

I want to contribute to Piston

@bvssvni
Copy link
Member Author

bvssvni commented Jan 11, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests