-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query about Mr. Mime's evolution chain correctness #274
Comments
I guess a problem might be that perhaps the data doesn't expect to have two chains like this, rather it expects a single starting mon and then potential branches after that... |
Hi! I checked out Bulbapedia and you're right! I think two chains will be better. Jr -> Mr Mime As of now we support species evolving into species. And we consider Mr Mime Galarian not a species. So we might not be able to support this scenario. Could you think of any other similar evolution? So to see if we might have dealt with the same issue in the past |
Off the top of my head I'm not aware of any similar evolution chains... For my purposes the following would work: I'm just building a Pokédex app and am displaying the evolution chains. I have to do some inference around the regional forms, so mons like sandshrew that have a single chain but Alolan forms of each stage I just duplicate based on the forms found in the mon's data. Some others need a bit more smarts (though similar logic), such as perhaps Scyther evolving to either Scizor or Kleavor. So with the above chains I could infer that as Mr. Rime is from Galar and Mr. Mime has a Galarian form then the second chain should be Jr -> Mime (Galar) -> Rime and I imagine I can infer that the first chain is just Jr -> Mime (Kanto) Whether that makes sense for all use cases Is perhaps another thing... It's certainly a bit weird to see Mime as the second stage in both chains... Ideally including the form in the chain would probably solve everything, but that's no small task I imagine and could cause issues to the consumers of the API if not done carefully |
Incidentally I've worked round the issue in my project by hardcoding the suggested evolution chain, so if you wanted to keep the data as-is that works for me! |
I wanted to enquire about whether anyone agreed with me that Mr. Mime's evolution chain should be modified.
This might just be something that suits my project, so feel free to say "nah it's how it's intended"!
Currently it's
Mime Jr. -> Mr. Mime -> Mr. Rime
(api-data/data/api/v2/evolution-chain/57/index.json
Line 75 in 8ff36d3
AFAIK the actual reality is:
Mime Jr. -> Mr. Mime
andGalarian Mr. Mime -> Mr. Rime
So would it be best to split the evolution chain in two, otherwise the only assumption you can really make from the data is that Mime Jr. can evolve all the way to Mr. Rime, which I don't believe is the case?
I could be wrong, I've not played most of the games, but what I've said is true in Pokemon Go at least!
I'd be happy to raise a PR with the change if it's agreed upon, just wanted to see what people thought before I went to the effort of figuring it out!
The text was updated successfully, but these errors were encountered: