-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to register function for NodeJS custom imports (no more flag?) #1220
Labels
alpha.3
breaking
CLI
documentation
Greenwood specific docs
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
SSR
v0.31.0
Milestone
Comments
Looks like this entered RC in Node starting with version |
11 tasks
This was referenced Dec 28, 2024
Looks like the flag might still be needed, which I guess is nice for additional composition / customizations from userland. Either way, the old flag will be deprecated, so we should definitely get onto this new API. |
This was referenced Dec 31, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alpha.3
breaking
CLI
documentation
Greenwood specific docs
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
SSR
v0.31.0
Summary
Although currently in RC, NodeJS implementation of custom loaders / imports / hooks is changing (in the better for Greenwood I think) moving from having to be be invoked with a flag (which is very clunky for downstream users
To something like this in our index.js instead
https://nodejs.org/api/module.html#customization-hooks
Details
Hopefully this lands as stable in a version of NodeJS soon, though I expect it to require a minimum NodeJS version given the release timeline, but hopefully in time for a 1.0 release on the Greenwood side.
This also means we should be able to remove all mentions of any pre-requisite configuration from our docs and would resolve #1217!
https://www.greenwoodjs.io/docs/server-rendering/#custom-imports
The text was updated successfully, but these errors were encountered: